From bb9121dbd4690405b54e7e6ed6e711ead16435ac Mon Sep 17 00:00:00 2001 From: Rubidium Date: Mon, 10 May 2021 23:43:52 +0200 Subject: Fix: comparison of narrow type to wide type in loop (potential for infinite loops) --- src/story_gui.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/story_gui.cpp') diff --git a/src/story_gui.cpp b/src/story_gui.cpp index 0ed39ba04..ccb9ccf7b 100644 --- a/src/story_gui.cpp +++ b/src/story_gui.cpp @@ -776,7 +776,7 @@ public: case WID_SB_SEL_PAGE: { /* Get max title width. */ - for (uint16 i = 0; i < this->story_pages.size(); i++) { + for (size_t i = 0; i < this->story_pages.size(); i++) { const StoryPage *s = this->story_pages[i]; if (s->title != nullptr) { @@ -822,7 +822,7 @@ public: if (!list.empty()) { /* Get the index of selected page. */ int selected = 0; - for (uint16 i = 0; i < this->story_pages.size(); i++) { + for (size_t i = 0; i < this->story_pages.size(); i++) { const StoryPage *p = this->story_pages[i]; if (p->index == this->selected_page_id) break; selected++; -- cgit v1.2.3-54-g00ecf