From 6853df46c7d2867ef3c03a0b29ec8d33f060c696 Mon Sep 17 00:00:00 2001 From: yexo Date: Fri, 21 Sep 2012 20:28:23 +0000 Subject: (svn r24539) -Codechange [FS#5260]: make code simpler by using IsValidTile instead of manually checking the bounds (juanjo) --- src/ship_cmd.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/ship_cmd.cpp') diff --git a/src/ship_cmd.cpp b/src/ship_cmd.cpp index ae2c819db..9bf97fbd9 100644 --- a/src/ship_cmd.cpp +++ b/src/ship_cmd.cpp @@ -570,15 +570,12 @@ static void ShipController(Ship *v) } } } else { - DiagDirection diagdir; /* New tile */ - if (TileX(gp.new_tile) >= MapMaxX() || TileY(gp.new_tile) >= MapMaxY()) { - goto reverse_direction; - } + if (!IsValidTile(gp.new_tile)) goto reverse_direction; dir = ShipGetNewDirectionFromTiles(gp.new_tile, gp.old_tile); assert(dir == DIR_NE || dir == DIR_SE || dir == DIR_SW || dir == DIR_NW); - diagdir = DirToDiagDir(dir); + DiagDirection diagdir = DirToDiagDir(dir); tracks = GetAvailShipTracks(gp.new_tile, diagdir); if (tracks == TRACK_BIT_NONE) goto reverse_direction; -- cgit v1.2.3-54-g00ecf