From c10f7db5760594b1166872746eb0769232ed7b77 Mon Sep 17 00:00:00 2001 From: smatz Date: Wed, 22 Oct 2008 19:12:10 +0000 Subject: (svn r14514) -Codechange: use 'size' instead of 'length' for querystring and textbuf, explicitly say it includes the terminating zero -Fix: one couldn't rename things with too long default/automatic name -Fix: buffer overflow in console when too long (1024 bytes) command was entered --- src/network/network_chat_gui.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/network/network_chat_gui.cpp') diff --git a/src/network/network_chat_gui.cpp b/src/network/network_chat_gui.cpp index 552095ec9..12cda3a43 100644 --- a/src/network/network_chat_gui.cpp +++ b/src/network/network_chat_gui.cpp @@ -374,11 +374,11 @@ struct NetworkChatWindow : public QueryStringBaseWindow { /* If we are completing at the begin of the line, skip the ': ' we added */ if (tb_buf == pre_buf) { offset = 0; - length = tb->length - 2; + length = (tb->size - 1) - 2; } else { /* Else, find the place we are completing at */ offset = strlen(pre_buf) + 1; - length = tb->length - offset; + length = (tb->size - 1) - offset; } /* Compare if we have a match */ -- cgit v1.2.3-54-g00ecf