From 8795050ff75fc9594f02e45945b28c90bb8db642 Mon Sep 17 00:00:00 2001 From: rubidium Date: Thu, 18 Oct 2007 17:44:59 +0000 Subject: (svn r11290) -Fix: obiwan in the assertion that checked for overflows when writing a packet, causing still correctly sized packets to cause assertions. --- src/network/core/packet.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/network/core/packet.cpp') diff --git a/src/network/core/packet.cpp b/src/network/core/packet.cpp index 8d85e9ad5..0da9b1a07 100644 --- a/src/network/core/packet.cpp +++ b/src/network/core/packet.cpp @@ -133,7 +133,8 @@ void Packet::Send_uint64(uint64 data) void Packet::Send_string(const char* data) { assert(data != NULL); - assert(this->size < sizeof(this->buffer) - strlen(data) - 1); + /* The <= *is* valid due to the fact that we are comparing sizes and not the index. */ + assert(this->size + strlen(data) + 1 <= sizeof(this->buffer)); while ((this->buffer[this->size++] = *data++) != '\0') {} } -- cgit v1.2.3-70-g09d2