From 020dbb180a11d27b2064640953f3960ede09f9c6 Mon Sep 17 00:00:00 2001 From: peter1138 Date: Thu, 8 Jan 2009 12:05:14 +0000 Subject: (svn r14909) -Codechange: Remove global option for the extmidi driver and make it a driver parameter with the name cmd instead. This means if you have an "extmidi = ..." line in your config you must change it to "musicdriver = extmidi:cmd=...", in the [misc] section. --- src/music/extmidi.cpp | 13 +++++++++++-- src/music/extmidi.h | 1 + 2 files changed, 12 insertions(+), 2 deletions(-) (limited to 'src/music') diff --git a/src/music/extmidi.cpp b/src/music/extmidi.cpp index cba772506..6179501a6 100644 --- a/src/music/extmidi.cpp +++ b/src/music/extmidi.cpp @@ -17,10 +17,18 @@ #include #include +#ifndef EXTERNAL_PLAYER +#define EXTERNAL_PLAYER "timidity" +#endif + static FMusicDriver_ExtMidi iFMusicDriver_ExtMidi; const char* MusicDriver_ExtMidi::Start(const char* const * parm) { + const char *command = GetDriverParam(parm, "cmd"); + if (StrEmpty(command)) command = EXTERNAL_PLAYER; + + this->command = strdup(command); this->song[0] = '\0'; this->pid = -1; return NULL; @@ -28,6 +36,7 @@ const char* MusicDriver_ExtMidi::Start(const char* const * parm) void MusicDriver_ExtMidi::Stop() { + free(command); this->song[0] = '\0'; this->DoStop(); } @@ -68,9 +77,9 @@ void MusicDriver_ExtMidi::DoPlay() d = open("/dev/null", O_RDONLY); if (d != -1 && dup2(d, 1) != -1 && dup2(d, 2) != -1) { #if defined(MIDI_ARG) - execlp(msf.extmidi, "extmidi", MIDI_ARG, this->song, (char*)0); + execlp(this->command, "extmidi", MIDI_ARG, this->song, (char*)0); #else - execlp(msf.extmidi, "extmidi", this->song, (char*)0); + execlp(this->command, "extmidi", this->song, (char*)0); #endif } _exit(1); diff --git a/src/music/extmidi.h b/src/music/extmidi.h index b5af27722..bae1e1b4f 100644 --- a/src/music/extmidi.h +++ b/src/music/extmidi.h @@ -9,6 +9,7 @@ class MusicDriver_ExtMidi: public MusicDriver { private: + char *command; char song[MAX_PATH]; pid_t pid; -- cgit v1.2.3-70-g09d2