From 652c9cb6635cc5f72a32077fdcd4e0f4bcc859e0 Mon Sep 17 00:00:00 2001 From: frosch Date: Sun, 13 Mar 2011 21:34:21 +0000 Subject: (svn r22247) -Codechange: Update comments wrt. ForceRebuild() in command-scope. --- src/group_gui.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/group_gui.cpp') diff --git a/src/group_gui.cpp b/src/group_gui.cpp index 906b099ec..6cbd89920 100644 --- a/src/group_gui.cpp +++ b/src/group_gui.cpp @@ -260,11 +260,8 @@ public: */ virtual void OnInvalidateData(int data = 0, bool gui_scope = true) { - if (!gui_scope) return; - /* We can only set the trigger for resorting/rebuilding. - * We cannot safely resort at this point, as there might be multiple scheduled invalidations, - * and a rebuild needs to be done first though it is scheduled later. */ if (data == 0) { + /* This needs to be done in command-scope to enforce rebuilding before resorting invalid data */ this->vehicles.ForceRebuild(); this->groups.ForceRebuild(); } else { @@ -272,6 +269,7 @@ public: this->groups.ForceResort(); } + /* Process ID-invalidation in command-scope as well */ if (this->group_rename != INVALID_GROUP && !Group::IsValidID(this->group_rename)) { DeleteWindowByClass(WC_QUERY_STRING); this->group_rename = INVALID_GROUP; -- cgit v1.2.3-54-g00ecf