From 55aff858c56e3f327de3f030d347762dc6ad6ea2 Mon Sep 17 00:00:00 2001 From: Darkvater Date: Wed, 5 Apr 2006 20:11:01 +0000 Subject: (svn r4291) - Fix: validate all received strings for correctness. This fixes potential crashes on invalid clients/servers (thanks test for bringing this to our attention) --- network_data.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'network_data.c') diff --git a/network_data.c b/network_data.c index ffb4bdddc..977e08447 100644 --- a/network_data.c +++ b/network_data.c @@ -273,6 +273,7 @@ uint64 NetworkRecv_uint64(NetworkClientState *cs, Packet *packet) void NetworkRecv_string(NetworkClientState *cs, Packet *p, char* buffer, size_t size) { int pos; + char *bufp = buffer; /* Don't allow reading from a closed socket */ if (cs->quited) @@ -289,6 +290,8 @@ void NetworkRecv_string(NetworkClientState *cs, Packet *p, char* buffer, size_t ++pos; } p->pos = pos; + + str_validate(bufp); } // If PacketSize changes of size, you have to change the 2 packet->size -- cgit v1.2.3-70-g09d2