From ee27bb497c0790d86da6025fa48034f01f36d6e0 Mon Sep 17 00:00:00 2001 From: Darkvater Date: Sat, 21 Oct 2006 23:31:34 +0000 Subject: (svn r6884) -Codechange: Add strict bounds checking in string formatting system. The last parameter should point to the end of the buffer (eg lastof(buf)) Courtesy of Tron. --- main_gui.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'main_gui.c') diff --git a/main_gui.c b/main_gui.c index 1a5cacbac..5ddab1c81 100644 --- a/main_gui.c +++ b/main_gui.c @@ -658,7 +658,7 @@ static int GetStringListMaxWidth(StringID base_string, byte count) max_width = 0; for (i = 0; i != count; i++) { - GetString(buffer, base_string + i); + GetString(buffer, base_string + i, lastof(buffer)); width = GetStringBoundingBox(buffer).width; if (width > max_width) max_width = width; } @@ -2108,7 +2108,7 @@ static bool DrawScrollingStatusText(const NewsItem *ni, int pos) str = ni->string_id; } - GetString(buf, str); + GetString(buf, str, lastof(buf)); s = buf; d = buffer; -- cgit v1.2.3-54-g00ecf