From 494c56475f04f0753d1ef7b8126612d3017df861 Mon Sep 17 00:00:00 2001 From: Darkvater Date: Sat, 21 Oct 2006 23:31:34 +0000 Subject: (svn r6884) -Codechange: Add strict bounds checking in string formatting system. The last parameter should point to the end of the buffer (eg lastof(buf)) Courtesy of Tron. --- industry_gui.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'industry_gui.c') diff --git a/industry_gui.c b/industry_gui.c index a5c9258bc..b97595e7f 100644 --- a/industry_gui.c +++ b/industry_gui.c @@ -536,12 +536,12 @@ static int CDECL GeneralIndustrySorter(const void *a, const void *b) char buf1[96]; SetDParam(0, i->town->index); - GetString(buf1, STR_TOWN); + GetString(buf1, STR_TOWN, lastof(buf1)); if (j != _last_industry) { _last_industry = j; SetDParam(0, j->town->index); - GetString(_bufcache, STR_TOWN); + GetString(_bufcache, STR_TOWN, lastof(_bufcache)); } r = strcmp(buf1, _bufcache); } -- cgit v1.2.3-54-g00ecf