From 494c56475f04f0753d1ef7b8126612d3017df861 Mon Sep 17 00:00:00 2001 From: Darkvater Date: Sat, 21 Oct 2006 23:31:34 +0000 Subject: (svn r6884) -Codechange: Add strict bounds checking in string formatting system. The last parameter should point to the end of the buffer (eg lastof(buf)) Courtesy of Tron. --- graph_gui.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'graph_gui.c') diff --git a/graph_gui.c b/graph_gui.c index 5919e4505..9502ba1cd 100644 --- a/graph_gui.c +++ b/graph_gui.c @@ -1135,11 +1135,11 @@ static int CDECL SignNameSorter(const void *a, const void *b) const Sign *sign1 = *(const Sign**)b; char buf1[64]; - GetString(buf1, sign0->str); + GetString(buf1, sign0->str, lastof(buf1)); if (sign1 != _last_sign) { _last_sign = sign1; - GetString(_bufcache, sign1->str); + GetString(_bufcache, sign1->str, lastof(_bufcache)); } return strcmp(buf1, _bufcache); // sort by name -- cgit v1.2.3-54-g00ecf