From b4dbfe5e599cf1557968890c74d7f10b05926b4a Mon Sep 17 00:00:00 2001 From: peter1138 Date: Sun, 14 Jan 2007 18:38:40 +0000 Subject: (svn r8120) -Fix (r8055): Station cargo waiting value clamp should be signed not unsigned. This resulted in cargo magically appearing... --- src/station_cmd.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp index ea89c45f9..e0e508923 100644 --- a/src/station_cmd.cpp +++ b/src/station_cmd.cpp @@ -2524,8 +2524,8 @@ static void UpdateStationRating(Station *st) // if rating is <= 127 and there are any items waiting, maybe remove some goods. if (rating <= 127 && waiting != 0) { uint32 r = Random(); - if ( (uint)rating <= (r & 0x7F) ) { - waiting = max(waiting - ((r >> 8)&3) - 1, 0U); + if (rating <= (int)GB(r, 0, 7)) { + waiting = max(waiting - (int)GB(r, 8, 2) - 1, 0); waiting_changed = true; } } -- cgit v1.2.3-54-g00ecf