From ad8057ab7652aa0ed6ab6d84403bcab7ee013df3 Mon Sep 17 00:00:00 2001
From: smatz <smatz@openttd.org>
Date: Tue, 13 May 2008 18:39:15 +0000
Subject: (svn r13072) -Fix (r12995): possible out-of-bounds access

---
 src/engine.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/engine.cpp b/src/engine.cpp
index ac50f811b..715fdebf8 100644
--- a/src/engine.cpp
+++ b/src/engine.cpp
@@ -120,7 +120,11 @@ Engine::~Engine()
  */
 void EngList_Sort(EngineList *el, EngList_SortTypeFunction compare)
 {
-	qsort(&((*el)[0]), el->size(), sizeof(EngineID), compare);
+	size_t size = el->size();
+	/* out-of-bounds access at the next line for size == 0 (even with operator[] at some systems)
+	 * generally, do not sort if there are less than 2 items */
+	if (size < 2) return;
+	qsort(&(el->at(0)), size, sizeof(EngineID), compare);
 }
 
 /** Sort selected range of items (on indices @ <begin, begin+num_items-1>)
-- 
cgit v1.2.3-70-g09d2