From 9c75ffb8c5b2226d2a66ad49552a82d5d7b6b15b Mon Sep 17 00:00:00 2001 From: frosch Date: Sat, 12 Dec 2009 22:15:14 +0000 Subject: (svn r18471) -Codechange/Fix: [NoAI] Deduplicate code betweeen AIVehicle::SkipToVehicleOrder and AIOrder::SkipToOrder. They are the same. Also ORDER_CURRENT was not allowed for the latter, but well... --- src/ai/api/ai_order.cpp | 2 ++ src/ai/api/ai_vehicle.cpp | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/ai/api/ai_order.cpp b/src/ai/api/ai_order.cpp index 5ecdb27a6..fba80ec59 100644 --- a/src/ai/api/ai_order.cpp +++ b/src/ai/api/ai_order.cpp @@ -397,6 +397,8 @@ static const Order *ResolveOrder(VehicleID vehicle_id, AIOrder::OrderPosition or /* static */ bool AIOrder::SkipToOrder(VehicleID vehicle_id, OrderPosition next_order) { + next_order = AIOrder::ResolveOrderPosition(vehicle_id, next_order); + EnforcePrecondition(false, IsValidVehicleOrder(vehicle_id, next_order)); return AIObject::DoCommand(0, vehicle_id, next_order, CMD_SKIP_TO_ORDER); diff --git a/src/ai/api/ai_vehicle.cpp b/src/ai/api/ai_vehicle.cpp index acf1a3bd8..91c3cf547 100644 --- a/src/ai/api/ai_vehicle.cpp +++ b/src/ai/api/ai_vehicle.cpp @@ -195,11 +195,7 @@ /* static */ bool AIVehicle::SkipToVehicleOrder(VehicleID vehicle_id, AIOrder::OrderPosition order_position) { - order_position = AIOrder::ResolveOrderPosition(vehicle_id, order_position); - - EnforcePrecondition(false, AIOrder::IsValidVehicleOrder(vehicle_id, order_position)); - - return AIObject::DoCommand(0, vehicle_id, order_position, CMD_SKIP_TO_ORDER); + return AIOrder::SkipToOrder(vehicle_id, order_position); } /* static */ bool AIVehicle::ReverseVehicle(VehicleID vehicle_id) -- cgit v1.2.3-54-g00ecf