From 7fbf705c41b2c902e5b2fa3f16cae421e42800b2 Mon Sep 17 00:00:00 2001 From: Patric Stout Date: Sun, 31 Jan 2021 10:36:07 +0100 Subject: Fix 2db88953: default Network Server List sorter put compatible servers in wrong order (#8626) If a server is compatible, it falls back to sorting by clients. This used to be in reverse, so full servers are on top. With the codechange commit, this was removed by accident, and as such empty servers were on top. This is silly. --- src/network/network_gui.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/network/network_gui.cpp b/src/network/network_gui.cpp index a2c2cac19..42915c410 100644 --- a/src/network/network_gui.cpp +++ b/src/network/network_gui.cpp @@ -330,10 +330,9 @@ protected: if (r == 0) r = b->info.compatible - a->info.compatible; /* Passworded servers should be below unpassworded servers */ if (r == 0) r = a->info.use_password - b->info.use_password; - /* Finally sort on the number of clients of the server */ - if (r == 0) return NGameClientSorter(a, b); - return r < 0; + /* Finally sort on the number of clients of the server in reverse order. */ + return (r != 0) ? r < 0: !NGameClientSorter(a, b); } /** Sort the server list */ -- cgit v1.2.3-70-g09d2