Age | Commit message (Collapse) | Author |
|
Although it was an accessor, nor his usage nor the values were clear.
|
|
|
|
|
|
code and proofreading, thanks to peter1138 for another lot of code and ideas.
|
|
of the comma operator
|
|
get information about rail tiles
|
|
|
|
|
|
shiny new functions and mark some strange constructs with XXX
|
|
if there's a transport route at all under the bridge
|
|
make the only place which still extracted that info diretly use the wrapper
|
|
(the line above already says what's going on)
|
|
instead of again and again
|
|
with similar functionality
|
|
offset once instead of all over the place; also use UpdateSignalsOnSegment() instead of SetSignalsOnBothDir(), because this is sufficient
|
|
under bridges works; also remove an unnecessary local variable
|
|
|
|
bridge after removing it. For crossings we can always use .m2 because it is already 0 when not owned by a town.
|
|
|
|
removal loop
|
|
comprehensible and add the needed accessors
|
|
Fix r3887
|
|
bridge ramp
|
|
|
|
part
|
|
Note: This slightly changes the behavior of GetAnyRoadBits() to only return a road piece for the start of the bridge ramp instead of a full ROAD_[XY]
|
|
|
|
road) under bridges
|
|
magic numbers and generic names
|
|
Existing bug: When restoring a road piece which belongs to a town the town index unconditionally gets set to 0
|
|
IsTunnel(), which just checks for a tunnel, but not the tile type as IsTunnelTile() does
|
|
codes instead of using this global variable
|
|
overwritten just a few lines later without being used in between
|
|
generic byte and don't fill arbitrary data into inappropriate types
|
|
|
|
Direction to DiagDirection as that's what it really operates on
|
|
DiagDirection and friends
|
|
result and give it a less ambiguous name (IsTunnelInWay)
|
|
|
|
and friends
|
|
|
|
road pieces
|
|
|
|
building a tunnel
|
|
comprehensible
This implementation is also significantly shorter because it removes many redundant checks
|
|
|
|
it was just a complicated way of writing GetTileSlope(tile, NULL)
|
|
|
|
add consts, reduce indentation level by short-circuit logic, convert if cascades to switch, whitespace, bracing, plus some minor stuff
|
|
- Don't treat non-booleans as booleans
- Reduce variable scope
- Bracing
- Use DeMorgan's law to make conditionals easier to read
- if cascade -> switch
- Replace some magic numbers by symbolic names
- Avoid assignments within other statements
|