summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-05-02Codechange: Acquire video buffer before taking game state lock to prevent ↵Milek7
erratic fast forward behaviour (#9140)
2021-05-02Codechange: Validate custom station platform layout tiles are permitted ↵Peter Nelson
values only.
2021-05-02Codechange: Use std::vector for NewGRF station tile sprite layouts.Peter Nelson
2021-05-02Codechange: Use std::vector for NewGRF station platform layouts.Peter Nelson
This avoids the need to custom memory management and additional members. This also resolves use-after-free if modifying copied layouts, so presumably nobody has ever done that.
2021-05-02Fix #9147: Delay making screenshots until the next draw tick as we may not ↵Michael Lutz
access the video buffer from the game thread.
2021-05-02Codechange: Generalise the delayed blitter change to a generic video driver ↵Michael Lutz
command queue.
2021-05-02Fix: [NewGRF] industry variable 66 and object variable 46 clamped the ↵frosch
squared-euclidian distance to 16 bit, when they should not.
2021-05-02Fix: [NewGRF] industry variables 65 and 66 ignored the parameter, and always ↵frosch
used the north tile.
2021-05-02Fix: [Network] Reading beyond the length of the server's ID when hashing ↵rubidium42
password Under normal circumstances the server's ID is 32 characters excluding '\0', however this can be changed at the server. This ID is sent to the server for company name hashing. The client reads it into a statically allocated buffer of 33 bytes, but fills only the bytes it received from the server. However, the hash assumes all 33 bytes are set, thus potentially reading uninitialized data, or a part of the server ID of a previous game in the hashing routine. It is still reading from memory assigned to the server ID, so nothing bad happens, except that company passwords might not work correctly.
2021-05-02Fix: Update text effect size when font zoom is changed. (#9174)PeterN
2021-05-02Fix: Crash when extra viewport height is zero with sign in view. (#9175)PeterN
If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
2021-05-02Codechange: Warn if randomaction2 group count is not a power of 2.Peter Nelson
Previously noted by a comment, this does not need to be guarded against as non-powers of 2 will not cause issues beyond the choice of results being reduced.
2021-05-02Cleanup: Use range iterator to evaluate DeterministicSpriteGroup.Peter Nelson
2021-05-02Cleanup: Use std::vector in RandomSpriteGroup.Peter Nelson
2021-05-02Cleanup: Use std::vector in DeterministicSpriteGroup.Peter Nelson
2021-05-02Cleanup: Use std::vector in RealSpriteGroup.Peter Nelson
2021-05-01Codechange: move some OS abstraction method implementations out of the headerrubidium42
2021-05-01Codechange: encapsulate network error handlingrubidium42
2021-05-01Codechange: rename NetworkError to ShowNetworkErrorrubidium42
2021-05-01Fix 3d7ab09: stopped trains not updating viewport hash when reversed for a ↵Matt Kimber
second time (#9165)
2021-05-01Fix #6598: Prevent invalid memory accesses when abandoning a join from ↵rubidium42
within a network game One could join a network game from within an already running network game. This would call a NetworkDisconnect, but keeps the UI alive. If, during that process the join is aborted, e.g. by cancelling on a password dialog, you would still be in your network game but also get shown the server list. Solve all the underlying problems by falling back to the main UI when (re)connecting to a(nother) server.
2021-05-01Codechange: Move join information into a single structurerubidium42
2021-05-01Fix #6598: Do not disconnect before company number validationrubidium42
NetworkClientConnectGame already does a NetworkDisconnect, so no reason to do it here
2021-05-01Change: [Console] Show help when passing invalid company numberrubidium42
2021-05-01Feature: make the town directory horizontally resizablerubidium42
2021-05-01Fix #9152, Fix #9153: screenshot command showed error messages when successfulrubidium42
2021-05-01Codechange: Scale sprite font height once on init instead of every call to ↵Peter Nelson
GetHeight(). Scaling is not expensive, but it does not change either, and this avoids the need for a virtual method call. This cascades back to all GetCharacterHeight(FS_xxx) and FONT_HEIGHT_xxx calls.
2021-05-01Cleanup: Use GetDefaultFontHeight() call instead of direct access.Peter Nelson
This makes this part of font size setup in FreeTypeFontCache consist with OSX and Windows variants.
2021-04-30Fix: Cargo legend blob in cargo payment rate window did not rescale.Peter Nelson
2021-04-30Fix: Scale cargo lines in industry chain window.Peter Nelson
Replaces constant pixel values with values scaled based on font size. This allows the industry chain to maintain a consistent look across different sizes. Previously all except cargo line height were fixed.
2021-04-30Fix: Scale industry chain legend blob by font size.Peter Nelson
2021-04-30Fix: Improved scaling and spacing of sign list window.Peter Nelson
Both company icon sprite and text now centred within each row, and extra padding added to avoid the sprites running into each other.
2021-04-30Fix: Scale legend blobs in Fund new industry window.Peter Nelson
2021-04-30Fix: Scale smallmap legend 'blob' to fit text.Peter Nelson
2021-04-30Fix: Tidy up sizing of sprite aligner window sprite list.Peter Nelson
2021-04-30Fix: Company Key window scaling.Peter Nelson
2021-04-30Fix: Use unscaled values for padding OSKPeter Nelson
2021-04-30Codechange: Use text lines instead of pixel height of font for link graph ↵Peter Nelson
widgets.
2021-04-30Codechange: Apply minimum size to toolbar widgetsPeter Nelson
2021-04-30Codechange: No longer necessary to manually resize volume sliders.Peter Nelson
2021-04-30Fix: Recalculate padding and minimum sizes when GUI or Font zoom is changed.Peter Nelson
2021-04-30Cleanup: Set unchanging scrollbar properties in constructor.Peter Nelson
2021-04-30Cleanup: Call SetMinimalSize instead of setting min_y directly.Peter Nelson
2021-04-30Fix: Specify width when width is required instead of top.Peter Nelson
2021-04-30Codechange: Simplify calling of DrawCharCentered()Peter Nelson
2021-04-30Cleanup: Tidy up resize, fill and minimal size on widgets in town list window.Peter Nelson
2021-04-30Cleanup: Remove fairly redundant DrawDropdown() function.Peter Nelson
2021-04-30Cleanup: Horizontal widget size is commonly width rather than length.Peter Nelson
2021-04-30Codechange: Use C++ features for train wagon overrides. (#9141)PeterN
This removes the need for C-style array management and allows use of iterators to perform wagon override lookups.
2021-04-30Remove: performance measurements in YAPFPatric Stout
YAPF was constantly measuring its performance, but only at certain debug-levels this information was shown. Now after years, I sincerely wonder if anyone still knows about this feature and who still use it. Especially with the new framerate window, this detailed performance is not as meaningful anymore as it once was.