Age | Commit message (Collapse) | Author |
|
tags and (more than just) a few comments style.
|
|
This major feature-fix keeps track of the value of transfers offloaded at a station, and hands on to a loading vehicle a credit note proportionate to the cargo loaded. The transferring vehicle is paid only for the distance it has travelled. eg. B-C in a transfer chain A-B-C-D.
When the final cargo is delivered, these credit notes are cashed, and the final vehicle is paid for A-D minus any credit notes it is carrying. The company bank balance increases by the value of the A-D route.
You still need to set up a profitable route; it is still easy to make a loss on transfers by bad planning. :)
|
|
Replace tests with magic numbers by a simple extraction template for command parameters
|
|
Remove unnecessary EnsureNoVehicle() checks because they are
- pointless per se (f.e. there are no vehicles on house tiles)
- done again (f.e. using CMD_LANDSCAPE_CLEAR just a few lines later)
|
|
files with the @file tag as well as a few general comments style
|
|
stops as if it were removing a normal road tile (consider the local authority and such).
-Fix (r8735): remove drive through road stops on town owned roads when going bankrupt/being removed.
|
|
outside of the local authority.
|
|
Remove {,u}intswap() and replace them by Swap()
|
|
-Codechange: Split MakeRoadStop() into MakeRoadStop() and MakeDriveThroughRoadStop() for more clarity and less possibilities to use it incorrect
|
|
-Regression (r7585): On load calculate the station rectangle for all savegames, not just savegames with at least version 27
|
|
struct array (with accessor) and implement new initialization method using cargo labels.
|
|
Variable scope, const
|
|
|
|
Simplify MoveGoodsToSation() under the assumption that 0 is less or equal than 0
|
|
Reduce variable scope
|
|
road' bit was not set.
|
|
Remove the unused function AllocateStation() which was left over from r8125
|
|
Remove the possiblity to take over stations with OWNER_NONE by building a station next to it
-Fix: It was possible to take over buoys by building a station next to them
Also remove the now unnecessary special case which prevented taking over oilrigs
NOTE: 0.5 candidate
|
|
Adapt GetClosestStationFromTile() more to the way it is used:
- All but deleted stations get filtered later, so do not include non-deleted station in the first place
- Remove the two parameters, which are the same for all callers
|
|
A spectator cannot build stations, so do not include a special case for him
|
|
-Codechange: Use a more generic test, which tests the allowed aircraft instead of hardcoding the airport type numbers, to generate station names
|
|
-Codechange: Do not hardcode the catchment radius of airports, but hold the information in AirportFTAClass
-Fix (r979): The default AI tested possible airport locations with a fixed catchment radius instead of the radius of the to be built airport
|
|
into the cmd code.
|
|
Abbreviate GetAirport(st->airport_type) to st->Airport()
|
|
robust and add roadstops.grf to the list of required grfs.
|
|
work of mart3p.
|
|
road vehicles with enums. Original patch by mart3p.
|
|
GetPlatformLength because that is what it really does. Overload it because there is already a GetPlatformLength (one gives the length of the whole platform, the other gives the remaining length in a given direction). Turned both functions into methods of Station. While messing around with it, fix a problem where loading times for overhanging trains are miscomputed.
|
|
|
|
involves changing the enum of airport blocks to a static const uint64 as SOME platforms do not support 64-bit enums
|
|
|
|
functions.
|
|
|
|
set the ownership of the water tile when the buoy is removed. This solves the issue of removing ownership from canal tiles thus making is possible for other players to remove the canal tile.
|
|
|
|
static
|
|
Remove unnecessary pointer mumbo-jumbo from FindRoadStopSpot()
|
|
conflict no longer exists.
|
|
|
|
in the scenario editor. Add a button to the landscape window to do this.
|
|
-Fix (?): When removing an oil rig replace the station tile by water, not bare land
|
|
-Codechange: Remove the unnecessary attributes Station::{bus,lorry}_tile_obsolete by replacing them with a scan of the map for existing road stops when loading old savegames
|
|
Remove the unused remnants of {bus,truck}_stop_status_obsolete
(though I wonder a bit why this information doesn't get converted on load *shrug*)
|
|
Remove the unused remnants of blocked_months_obsolete
|
|
Turn GetPrimaryRoadStop() into a method of struct Station
|
|
-Codechange: Remove the superfluous attribute RoadStop::prev
|
|
-Simplifies assignment from raw pointers
-Should be harder to crash the program by incorrect assignment into it.
-Should help with MorphOS compilation errors
|
|
|
|
and changed a one-member enum into a static const. Simplify their naming and add some doxygen-comments to RoadStop
|
|
Simplify r8399
|