Age | Commit message (Collapse) | Author |
|
we had
While at it, replace OTTD_ASSERT with WITH_ASSERT, as this
is always set if assert() is valid. No matter if NDEBUG is set
or not.
|
|
Basically, this changes "SaveLoad *" to either:
1) "SaveLoadTable" if a list of SaveLoads was meant
2) "SaveLoad &" if a single entry was meant
As added bonus, this removes SL_END / SLE_END / SLEG_END. This
also adds core/span.hpp, a "std::span"-lite.
|
|
|
|
|
|
that) in the middle of a C-string
|
|
(#9306)
This is mostly done as there are now constraints on settings.ini you might not
expected. For example, conditional settings always have to come last, as otherwise
they would influence the index.
|
|
|
|
|
|
It is not nice to have your definition say you won't change a value
while in fact the whole reason for your existance is to change it.
|
|
This could have unwanted side-effects, as it could change the
source for ever and ever.
|
|
This to be more explicit the function changes the value, and not
returns yes/no.
|
|
|
|
|
|
distinction between (non)company
|
|
|
|
|
|
|
|
|
|
resolved statically
This as during construction the sub class has not been initialized yet, and
during destruction the sub class has already been destroyed, so the overriding
virtual function would be accessing uninitialized data.
|
|
|
|
comments) (#9203)
|
|
|
|
|
|
|
|
|
|
CMD_SET_GROUP_FLAG.
|
|
|
|
allocated instead of crashing the whole game
|
|
|
|
|
|
CheckCompanyHasMoney() was also executed when not using DC_EXEC,
resulting in an error about shortage of money instead of the
estimation.
This mostly is a problem for AI players, as they will have no
way to know how much it would have cost.
|
|
|
|
|
|
effect if needed (#8573)
|
|
|
|
cargo (#8544)
Of course this translates into AICargo.GetName() for AIs and
GSCargo.GetName() for GameScripts.
|
|
|
|
|
|
Also enables the Reset button while in-game for AI configs.
|
|
|
|
|
|
|
|
|
|
|
|
It was rather confusing that "library_name" was calculated, and
then not used to do the FindLibrary() call. Flipping those two
blocks around makes it a bit more sane to read.
|
|
See commit fae34ee7 for details. The documentation simply never
got updated.
|
|
|
|
|
|
|
|
|