Age | Commit message (Collapse) | Author |
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
a popup into a static message that only shows in non-release versions, just like the 'missing translations' message.
|
|
instead, which does the same in all use-cases.
|
|
|
|
when they are not supposed to, and truncate cargo appropiately if they are allowed to.
|
|
Eagle_rainbow)
|
|
have labels.
|
|
|
|
|
|
|
|
others were still regular inline), but make sure inline is always a 'forced' inline (I am looking at you MSVC)
|
|
coding style
|
|
|
|
|
|
applied correctly anymore as the configuration file is loaded after the first NewGRF scan
|
|
supplied by BaNaNaS tars, i.e. changelog and license.
|
|
to 'textfile', so it is more generic.
|
|
|
|
|
|
NewGRF indication.
|
|
|
|
|
|
forgotten
|
|
|
|
|
|
name becomes available
|
|
of GRFs with versions above 7.
|
|
|
|
choosing compatbile NewGRFs. (planetmaker)
|
|
search restrictions.
|
|
with action 14
|
|
|
|
railtype.
|
|
|
|
hide old NewGRFs / to choose the newest when loading compatible NewGRFs
|
|
|
|
user-changeable parameters
|
|
|
|
bitmask/bitset
|
|
palette for NewGRFs
|
|
|
|
a GRFText* to make translations possible
|
|
function co clone GRFConfig/GRFError
|
|
BaNaNaS instead of the initial (when the grf was added) md5sum from the gamelog. Neither method is 'better', but this way it is independent from the gamelog.
|
|
GRFConfig and move the GameLog operations directly to AfterLoad().
|
|
|
|
|
|
sure all members are properly initialized
|
|
subclassing it
|
|
allocating errors more uniform.
-Fix: some grf error messages didn't free the previous error messages, creating a memory leak
|