| Age | Commit message (Collapse) | Author |
|---|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
|
|
|
|
|
|
SaveLoadOperation to avoid nameclash with windows compiler toolkit.
|
|
|
|
authority window did not auto-resize according to their content when they were positioned at the bottom of the screen. (Eearslya)
|
|
client list. (_dp_)
|
|
sizes.
|
|
buttons with non-static width.
|
|
|
|
|
|
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
|
|
technically it's dead code
|
|
just UCS-2 to the window key press handlers.
|
|
rows and columns from the resize step size.
|
|
scrollbar capacity before that.
|
|
widgets.
|
|
window to its default size.
|
|
|
|
after construction.
|
|
to better reflect what they do
|
|
|
|
NewGRF list as for the server list.
|
|
values for size computations.
|
|
various sources (including Eagle_rainbow, MinchinWeb)
|
|
GUIList::NeedResort since the latter has the sideeffects.
|
|
(Eagle_rainbow)
|
|
|
|
list who tried to disguised themself as optimisations.
|
|
QueryStrings per widget instead.
|
|
QueryStringBaseWindow and directly use QueryString.
|
|
|
|
sense if it is smaller than the second one, also its unit is not pixels.
|
|
Window::OnEditboxChanged.
|
|
|
|
|
|
CANCEL buttons via QueryString members.
|
|
|
|
no effect whatsoever.
|
|
|
|
handled more generally.
|
|
|
|
|
|
blinking due to wrong magic constants (same as r17539).
|
|
functions.
|
|
selected anymore (adf88)
|
|
|
|
server instead of waiting for the requery loop (adf88)
|
|
|
