| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
|
|
padding.
|
|
as the toolbar. Otherwise they lack a size definition.
|
|
width instead of pixels.
|
|
|
|
the return is not NULL)
|
|
|
|
|
|
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
|
|
|
|
just UCS-2 to the window key press handlers.
|
|
messages; drawing complete multiline strings from the bottom, instead of manually breaking the strings and drawing those
|
|
|
|
after construction.
|
|
|
|
Eagle_rainbow)
|
|
QueryStrings per widget instead.
|
|
QueryStringBaseWindow and directly use QueryString.
|
|
|
|
|
|
Window::OnEditboxChanged.
|
|
|
|
|
|
CANCEL buttons via QueryString members.
|
|
|
|
|
|
|
|
functions.
|
|
|
|
understandable
|
|
|
|
|
|
NetworkClientInfo::GetByClientID
|
|
password input box
|
|
already in command scope.
|
|
OnInvalidateData().
|
|
position of the status bar.
|
|
possible options.
|
|
|
|
to TextColour
|
|
unrelated to the number of passed game days, i.e. don't stop aging chat messages when the server is paused
|
|
bit more descriptive
|
|
sensible name
|
|
while the chat message box was visible
|
|
|
|
|
|
consisted of unrelated values use static const (u)int
|
