summaryrefslogtreecommitdiff
path: root/src/network/network_base.h
AgeCommit message (Collapse)Author
2019-03-20Remove: ENABLE_NETWORK switchPatric Stout
This switch has been a pain for years. Often disabling broke compilation, as no developer compiles OpenTTD without, neither do any of our official binaries. Additionaly, it has grown so hugely in our codebase, that it clearly shows that the current solution was a poor one. 350+ instances of "#ifdef ENABLE_NETWORK" were in the code, of which only ~30 in the networking code itself. The rest were all around the code to do the right thing, from GUI to NewGRF. A more proper solution would be to stub all the functions, and make sure the rest of the code can simply assume network is available. This was also partially done, and most variables were correct if networking was disabled. Despite that, often the #ifdefs were still used. With the recent removal of DOS, there is also no platform anymore which we support where networking isn't working out-of-the-box. All in all, it is time to remove the ENABLE_NETWORK switch. No replacement is planned, but if you feel we really need this option, we welcome any Pull Request which implements this in a way that doesn't crawl through the code like this diff shows we used to.
2011-05-04(svn r22423) -Document: some network stuffrubidium
2011-04-22(svn r22368) -Codechange: move the IP address field from the ClientInfo to ↵rubidium
ClientSocket
2011-04-22(svn r22362) -Codechange: NetworkFindClientInfoFromClientID -> ↵rubidium
NetworkClientInfo::GetByClientID
2011-02-19(svn r22116) -Codechange: use PoolBase::Clean() at more placessmatz
2010-01-21(svn r18875) -Codechange: remove some unneeded bits from the network ↵rubidium
protocol and improve the naming of some variables
2010-01-15(svn r18809) -Codechange/Cleanup: remove unneeded headers from some files, ↵rubidium
if a header require a header make it include that header
2009-10-07(svn r17737) -Codechange: remove the chat window when you were chatting with ↵rubidium
someone who lost his/her connection or when you were team chatting and moved out of the company.
2009-08-21(svn r17248) -Fix: add GPL license notice where appropriaterubidium
2009-05-22(svn r16380) -Codechange: rename pool.hpp to pool_type.hppsmatz
2009-05-22(svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation ↵smatz
time, binary size and run time (with asserts disabled) should be improved
2009-05-22(svn r16377) -Codechange: unify FOR_ALL_* macros, use separate index ↵smatz
variable instead of var->index
2009-05-17(svn r16327) -Codechange: replace IsValidPoolItemID(index) by ↵smatz
PoolItem::IsValidID(index)
2009-05-16(svn r16326) -Codechange: replace GetPoolItemPoolSize() by ↵smatz
PoolItem::GetPoolSize()
2009-05-16(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)smatz
2009-04-04(svn r15947) -Codechange: replace uint32 client_ip with NetworkAddress ↵rubidium
client_address.
2008-12-23(svn r14730) -Codechange: remove the need for networkclientsockets and ↵rubidium
networkclientinfo structs to be in a contiguous piece of memory and put them in a pool. -Note: 255 should really be enough for now... making it any more means network protocol bumps.
2008-12-23(svn r14725) -Change: make it clearer why (and that) MAX_CLIENTS isn't the ↵rubidium
amount of slots in the array, but one less as a dedicated server takes a slot too.
2008-12-23(svn r14723) -Codechange: shuffling some stuff around to reduce indirect ↵rubidium
#include dependencies.