Age | Commit message (Collapse) | Author |
|
* Codechange: [Network] split CloseSocket and CloseConnection more clearly
- CloseSocket now closes the actual OS socket.
- CloseConnection frees up the resources to just before CloseSocket.
- dtors call CloseSocket / CloseConnection where needed.
|
|
statically in destructors
In the destructors of many of the network related classes Close() is called, just like the
top class in that hierarchy. However, due to virtual functions getting resolved statically
in the destructor it would always call the empty Close() of the top class.
Document the other cases where a virtual call is resolved statically.
|
|
|
|
|
|
When ever you saw this debug lines (which you never should), they
showed an empty address. It is also not very useful to have, as it
always points to a known server anyway.
|
|
|
|
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
connection, the client would for eternity try to read a packet and never timeout making it impossible to reconnect
|
|
Eagle_rainbow)
|
|
compile it, and doesn't need all the required dependencies
|
|
online content window (LordAro)
|
|
Subdirectory conversion (LordAro)
|
|
only with GS prefix (and in game/library)
|
|
that directory
|
|
coding style
|
|
|
|
doxygen can create better documentation
|
|
more likely to be updated [n].
|
|
the ifndef/define/endif lines.
|
|
style
|
|
|
|
hidden destructor call from Swap().
|
|
|
|
'generic' includes so compilation without network support doesn't get broken as easily by changes in header files
|
|
|
|
|
|
compile for XP SP2+). Also fix a MSVC warning.
|
|
|
|
up the mess when cancelling a download
|
|
|
|
resolving the hostname or connecting takes long/is timing out.
|
|
|
|
(content.openttd.org) where authors can upload they NewGRFS/AI etc. This should make joining servers that use only NewGRFs that are distributed via this system easier as the players can download the NewGRFs from in the game. It should also make it easier to see whether there are updates for NewGRFs and make the necessary updates.
|