summaryrefslogtreecommitdiff
path: root/src/network/core/tcp_content.cpp
AgeCommit message (Collapse)Author
2020-06-21Fix: Thread unsafe use of NetworkAddress::GetAddressAsStringJonathan G Rennison
Remove static buffer form of NetworkAddress::GetAddressAsString. This is used in multiple threads concurrently, and is not thread-safe. Replace it with a form returning std::string.
2019-11-10Cleanup: Removed SVN headersS. D. Cloudt
2019-04-10Codechange: Use null pointer literal instead of the NULL macroHenry Wilson
2019-03-20Remove: ENABLE_NETWORK switchPatric Stout
This switch has been a pain for years. Often disabling broke compilation, as no developer compiles OpenTTD without, neither do any of our official binaries. Additionaly, it has grown so hugely in our codebase, that it clearly shows that the current solution was a poor one. 350+ instances of "#ifdef ENABLE_NETWORK" were in the code, of which only ~30 in the networking code itself. The rest were all around the code to do the right thing, from GUI to NewGRF. A more proper solution would be to stub all the functions, and make sure the rest of the code can simply assume network is available. This was also partially done, and most variables were correct if networking was disabled. Despite that, often the #ifdefs were still used. With the recent removal of DOS, there is also no platform anymore which we support where networking isn't working out-of-the-box. All in all, it is time to remove the ENABLE_NETWORK switch. No replacement is planned, but if you feel we really need this option, we welcome any Pull Request which implements this in a way that doesn't crawl through the code like this diff shows we used to.
2014-04-23(svn r26482) -Codechange: add an include that allows us to undefine/redefine ↵rubidium
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2013-07-13(svn r25597) -Fix [FS#5635]: [Content] When the server closed the ↵rubidium
connection, the client would for eternity try to read a packet and never timeout making it impossible to reconnect
2013-07-13(svn r25593) -Cleanup: remove a few stale #definesrubidium
2013-07-07(svn r25573) -Change: make content list appear faster by allowing some ↵rubidium
window redraws in between
2012-11-08(svn r24674) -Fix (r24466, r23234) [FS#5358]: Downloaded heightmaps could ↵frosch
not be used anymore. (sbr)
2012-10-28(svn r24638) -Codechange: add some #ifndefs so MSU code doesn't need to ↵rubidium
compile it, and doesn't need all the required dependencies
2012-09-02(svn r24508) -Fix [FS#5281] (24488): Content GUI crashed after downloading a ↵frosch
NewGRF while it is selected.
2012-08-21(svn r24491) -Fix: compilation error with networking disabledrubidium
2012-08-20(svn r24488) -Feature [FS#5236]: add buttons to view textfiles from the ↵yexo
online content window (LordAro)
2012-08-13(svn r24466) -Codechange [FS#5236]: add general function for ContentType -> ↵yexo
Subdirectory conversion (LordAro)
2011-05-06(svn r22431) -Fix (r22399): NETWORK_RECV_STATUS_MALFORMED_PACKET != false.michi_cc
2011-05-01(svn r22399) -Codechange: replace some defines in the tcp/content code so ↵rubidium
doxygen can create better documentation
2011-01-22(svn r21886) -Codechange: move documentation towards the code to make it ↵rubidium
more likely to be updated [n].
2010-11-30(svn r21358) -Codechange: make some network function names conform to coding ↵rubidium
style
2010-10-15(svn r20924) -Codechange: make the game connection packet handling look more ↵rubidium
like UDP/content packet handling
2010-07-08(svn r20089) -Fix [FS#3932]: Access of already freed memory, esp. due to ↵frosch
hidden destructor call from Swap().
2010-03-23(svn r19508) -Codechange: remove semicolon after ↵smatz
DEFINE_UNAVAILABLE_CONTENT_RECEIVE_COMMAND and DEFINE_UNAVAILABLE_UDP_RECEIVE_COMMAND
2009-10-07(svn r17742) -Codechange: remove unused variable from Recv_Packetrubidium
2009-10-04(svn r17693) -Cleanup: remove some unneeded includesrubidium
2009-10-04(svn r17692) -Codechange: minor coding style fixessmatz
2009-08-21(svn r17248) -Fix: add GPL license notice where appropriaterubidium
2009-07-31(svn r17015) -Fix [FS#3075]: infinite recursion in content dependency checkingrubidium
2009-04-02(svn r15914) -Codechange: let the content handling make use of NetworkAddress.rubidium
2009-01-22(svn r15206) -Fix [FS#2567]: memory corruption due to not properly cleanup ↵rubidium
up the mess when cancelling a download
2009-01-17(svn r15126) -Feature: downloading content from a central server ↵rubidium
(content.openttd.org) where authors can upload they NewGRFS/AI etc. This should make joining servers that use only NewGRFs that are distributed via this system easier as the players can download the NewGRFs from in the game. It should also make it easier to see whether there are updates for NewGRFs and make the necessary updates.