Age | Commit message (Collapse) | Author |
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
In 10 years there is no commit to change how MorphOS works, and we
have no active maintainer for it. It is unlikely it works in its
current state (but not impossible).
With the arrival of SDL2 (and removal of SDL), MorphOS is no longer
support. There is an SDL2 port for MorphOS, but it is not maintained
by upstream SDL2, and nobody can currently test it out.
If anyone wants to re-add MorphOS, please do (revert this patch,
fix the problems, and create a Pull Request). If you need any help
doing so, let us know! It is not that we don't like MorphOS, it is
that we don't have anyone fixing the problems :(
|
|
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
|
|
in the network code
|
|
|
|
when SendPackets closed the connection
|
|
style
|
|
|
|
|
|
|
|
network_client.cpp
|
|
client before closing the connection. As a result the client would say 'connection lost' when the cause was something completely different.
|
|
NetworkSend_Init() is useless
|
|
|
|
|
|
|
|
|
|
to multiple sockets.
|
|
|
|
up the mess when cancelling a download
|
|
and connect to game servers.
|
|
is for UDP.
|
|
twice (found due to added assertion in r14730)
|
|
networkclientinfo structs to be in a contiguous piece of memory and put them in a pool.
-Note: 255 should really be enough for now... making it any more means network protocol bumps.
|
|
it's (way) more descriptive what it's used for.
|
|
identification ids and the indices into the clients/client info arrays.
|
|
headers so that nothing from the network directory needs to include basically all network headers.
|
|
including other headers in variables.h.
|
|
unneeded include from openttd.h.
|
|
logical place and remove about 50% of the includes of 'functions.h'
|
|
it is really needed.
|
|
(the @file tag MUST be found before any line of code, that includes preprocessor directives).
|
|
functions of NetworkTCPSocketHandler.
|
|
and use constructors and functions related to the reading/saving the packet size.
|
|
did not exist anymore and add comments to several variables/functions.
|
|
and move a little of NetworkClientState functionality to the NetworkSocketHandler. Move the rest of the NetworkClientState to the new NetworkTCPSocketHandler class/struct, which is not yet implemented in an object oriented manner. The UDP socket handler now extends the NetworkSocketHandler instead of having a reference to a NetworkClientState.
|
|
pointer to allocated memory instead of modifying the pointer given as parameter
|
|
stillunknown and pv2b.
|
|
renamed to .cpp)
|