| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
Eagle_rainbow)
|
|
the ifndef/define/endif lines.
|
|
|
|
packet for longer company names (in bytes), by truncating the names if needed
|
|
style
|
|
if a header require a header make it include that header
|
|
'generic' includes so compilation without network support doesn't get broken as easily by changes in header files
|
|
|
|
|
|
to multiple sockets.
|
|
|
|
is for UDP.
|
|
network related company information.
|
|
headers so that nothing from the network directory needs to include basically all network headers.
|
|
|
|
|
|
(the @file tag MUST be found before any line of code, that includes preprocessor directives).
|
|
first seen using 'class' now seen using 'struct'
-Codechange: 'typedef struct Packet' changed to 'struct Packet'
|
|
downloading the map from a game server when connecting from the command prompt and internal console.
|
|
NetworkSocketHandler, so it can also be used the TCP socket handler.
|
|
did not exist anymore and add comments to several variables/functions.
|
|
and move a little of NetworkClientState functionality to the NetworkSocketHandler. Move the rest of the NetworkClientState to the new NetworkTCPSocketHandler class/struct, which is not yet implemented in an object oriented manner. The UDP socket handler now extends the NetworkSocketHandler instead of having a reference to a NetworkClientState.
|
|
to set _network_available only once.
|
|
functions into network/core, so the can be reused in the masterserver_updater.
|
