| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
The public and protected interface to SmallVector are unchanged
SmallVector now requires that items be default constructible
This isn't an issue since some contained items were previously created
uninitialized.
Temporary default constructors are added to the following structs
- SmallPair
- SmallStackItem
- GRFPresence
Where vector<bool> is required, transition immediately to std::vector
to avoid returning proxy object references.
|
|
|
|
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
|
|
|
|
Save and heightmap names can be filtered.
|
|
|
|
|
|
SaveLoadOperation to avoid nameclash with windows compiler toolkit.
|
|
of _file_to_saveload.
|
|
DetailedFileType.
|
|
FiosType with it.
|
|
|
|
most of SaveLoadDialogMode
|
|
class.
|
|
and move both to FileList.
|
|
file list.
|
|
class.
|
|
function.
|
|
|
|
|
|
buttons with non-static width.
|
|
savegames without NewGRF information.
|
|
file io code instead of assuming MAX_PATH is okay
|
|
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
|
|
|
|
just UCS-2 to the window key press handlers.
|
|
window to its default size.
|
|
|
|
after construction.
|
|
|
|
QueryStrings per widget instead.
|
|
QueryStringBaseWindow and directly use QueryString.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
functions.
|
|
|
|
understandable
|
|
|
