Age | Commit message (Collapse) | Author |
|
|
|
This is a C++11 feature that allows the compiler to check that a virtual
member declaration overrides a base-class member with the same signature.
Also src/blitter/32bpp_anim_sse4.hpp +38 is no longer erroneously marked
as virtual despite being a template.
|
|
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
|
|
|
|
|
|
|
|
setting is changed.
|
|
|
|
AISettingsWindow (#7123)
|
|
|
|
|
|
when some parameters are hidden.
|
|
window. (adf88)
|
|
download window when opened from the AI/GS settings window.
|
|
|
|
windows.
|
|
clicking
|
|
"unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
|
|
dropdowns
|
|
rows and columns from the resize step size.
|
|
|
|
depend on their number of rows, since that changes when resizing the window.
|
|
widgets.
|
|
|
|
|
|
|
|
HotkeyList member.
|
|
|
|
declared in the cpp file.
|
|
window to its default size.
|
|
|
|
after construction.
|
|
AI/GS config window.
|
|
states in OnInvalidateData.
|
|
|
|
Always allow changing all script settings without setting difficulty to custom.
|
|
and highscore tables.
|
|
the window.
|
|
QueryStrings per widget instead.
|
|
QueryStringBaseWindow and directly use QueryString.
|
|
|
|
sense if it is smaller than the second one, also its unit is not pixels.
|
|
Window::OnEditboxChanged.
|
|
|
|
|
|
|
|
no effect whatsoever.
|
|
|
|
|
|
|