summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-21Update: Translations from eintstranslators
dutch: 28 changes by JanWillem russian: 1 change by Lone_Wolf
2019-03-20Fix #7390: Extra line removed by mistake caused server_password to disappear ↵peter1138
from settings.
2019-03-20Fix #7384: Industry Chain tooltips did not display on right-click.peter1138
This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
2019-03-20Codechange: Implement OnTooltip event for custom window tooltips.peter1138
This avoids windows from needing to know or care about tooltip delay settings.
2019-03-20Fix #7386: Measurement tooltip for tunnels, aqueducts & docks did not ↵peter1138
display or flickered. Measurement tooltip was auto-closed as the hover/right-click test for tooltips was not satisfied in this case. This is fixed by keeping the tooltip visible and instead explicitly closing the tooltip when the PlaceObject is cancelled/completed.
2019-03-20Remove: ENABLE_NETWORK switchPatric Stout
This switch has been a pain for years. Often disabling broke compilation, as no developer compiles OpenTTD without, neither do any of our official binaries. Additionaly, it has grown so hugely in our codebase, that it clearly shows that the current solution was a poor one. 350+ instances of "#ifdef ENABLE_NETWORK" were in the code, of which only ~30 in the networking code itself. The rest were all around the code to do the right thing, from GUI to NewGRF. A more proper solution would be to stub all the functions, and make sure the rest of the code can simply assume network is available. This was also partially done, and most variables were correct if networking was disabled. Despite that, often the #ifdefs were still used. With the recent removal of DOS, there is also no platform anymore which we support where networking isn't working out-of-the-box. All in all, it is time to remove the ENABLE_NETWORK switch. No replacement is planned, but if you feel we really need this option, we welcome any Pull Request which implements this in a way that doesn't crawl through the code like this diff shows we used to.
2019-03-19Remove: DOS supportPatric Stout
In 10 years there was no active development on DOS. Although it turned out to still work, the FPS was very bad. There is little interest in the current community to look into this. Further more, we like to switch to c++11 functions for threads, which are not implemented by DJGPP, the only current compiler for DOS. Additionally, DOS is the only platform which does not support networking. It is the reason we have tons of #ifdefs to support disabling networking. By removing DOS support, we can both use c++11 functions for threads, and remove all the code related to disabling network. Sadly, this means we have to see DOS go. Of course, if you feel up for the task, simply revert this commit, and implement stub c++11 functions for threads and stub functions for networking. We are more than happy to accept such Pull Request.
2019-03-19Update: Translations from eintstranslators
korean: 7 changes by telk5093
2019-03-18Codechange: fix Intel C++ Compiler linking issues.Patric Stout
GetAircraftFlightLevel<Aircraft> is only used in static functions inside aircraft_cmd.cpp. With GCC, Clang and MSVC this is not an issue, but on ICC fails linking, because it doesn't find this version of this template. Possibly these two pieces of information are linked. Explicit defining the function fixes the issue.
2019-03-17Fix f58fa80e: Wrong company performance rating when money exceeds INT_MAX. ↵stormcone
(#7382) Company performance rating calculation does not take into account the companies' money when those exceeds INT_MAX.
2019-03-17Update: Translations from eintstranslators
dutch: 1 change by JanWillem russian: 1 change by Lone_Wolf
2019-03-16Cleanup: Unused lang stringsCharles Pigott
2019-03-16Remove: OPFCharles Pigott
2019-03-16Update: Translations from eintstranslators
norwegian (bokmal): 1 change by Leifbk
2019-03-16Change: Use default value for invalid multi-string settings instead of ↵PeterN
clamping to min or max value. (#7361)
2019-03-16Fix: [AzurePipelines] vcpkg is now preinstalled on Windows imagesPatric Stout
So instead of integrating our own, we only copy our precompiled binaries into the right folder.
2019-03-15Update: Translations from eintstranslators
romanian: 8 changes by alexmerlin1985 dutch: 2 changes by JanWillem
2019-03-15Cleanup: Update changed string in language files.peter1138
2019-03-15Fix e66cec8f86: Permit loading of industry production callback with invalid ↵peter1138
cargo type. It is only an error if the invalid result is actually used. This will be silently ignored at the moment. It is still an error if a duplicate cargo type is returned.
2019-03-13Codechange: Make FindStationsAroundTile() out-parameter stations const to ↵peter1138
prevent incorrect modification.
2019-03-13Fix #7372: FindStationsAroundTiles() with caching returns no result for ↵peter1138
industry tiles. Currently this can only be triggered by NewGRF house tiles querying for cargo acceptance history of nearby stations (var 0x64) with a tile offset, and providing an offset that happens to point to an industry tile. This serves no useful purpose.
2019-03-13Cleanup: Remove questionable syntax in track drawingJohannes E. Krause
2019-03-13Cleanup: Remove questionable syntax in town rating displayJohannes E. Krause
2019-03-13Cleanup: Remove questionable syntax in GetOrderCmdFromTileJohannes E. Krause
2019-03-13Cleanup: Remove questionable syntax in HQ size calculationJohannes E. Krause
2019-03-13Cleanup: Remove questionable syntax in station rating calculationJohannes E. Krause
2019-03-12Codechange: Update town sign on population change only when population is ↵Gabda
shown (#7368)
2019-03-11Update: Translations from eintstranslators
finnish: 110 changes by hpiirai ukrainian: 149 changes by nsergiy
2019-03-11Change: Include _current_company in crashlog AI config lineJonathan G Rennison
_current_company is not currently logged anywhere in the crashlog. _local_company is logged, despite being much less useful than _current_company. This change logs _current_company alongside _local_company.
2019-03-11Fix: don't include xaudio2 if you are not going to compile itPatric Stout
This is more in trend with other files, where if the driver is not selected, we don't even attempt to compile it.
2019-03-11Fix: MingW and MSVC compiled strgen had different path separator behaviourPatric Stout
If it was compiled with MingW, both / and \ were accepted as path separator. On MSVC, only \ was. This is an unexpected difference between binaries for the same platform. Remove this discrepancy by accepting both / and \ on all platforms.
2019-03-11Codechange: check if a define is set directly, instead of indirectlyPatric Stout
config.lib happens to set GLOBAL_DATA_DIR in case it is not DOS and not OS2, but this kind of deduction is annoying to maintain. It is better to just check if the define you want to use is set, and leave it to config.lib to set it or not depending on the OS.
2019-03-11Codechange: "basedir.h" is a system include, not a localPatric Stout
2019-03-11Codechange: ICU_SORT is in reality ICU_I18N (according to their CMake files)Patric Stout
By naming it in a different way, things get a bit confusing. Especially if we are switching to CMake, which autodetects these things, we need to use the name the authors of ICU gave it; not our interpertation of that name.
2019-03-11Codechange: ICU_LAYOUT is in reality ICU_LX (according to their CMake files)Patric Stout
By naming it in a different way, things get a bit confusing. Especially if we are switching to CMake, which autodetects these things, we need to use the name the authors of ICU gave it; not our interpertation of that name.
2019-03-11Codechange: liblzma is called liblzma, how ever strange that might bePatric Stout
It is the only library we use that calls itself with 'lib' in the name. This might be confusing, but with the arrival of cmake a lot of these things are automated. And detection will find 'liblzma', not 'lzma', like with 'lzo', 'zlib', ..
2019-03-11Codechange: make clear that SSE is a flag you can switchPatric Stout
2019-03-11Codechange: the flag is not if you have threads, but if you want to use themPatric Stout
2019-03-11Codechange: fix indentation of source.listPatric Stout
2019-03-10Update: Translations from eintstranslators
finnish: 214 changes by hpiirai norwegian (bokmal): 10 changes by Leifbk russian: 2 changes by Lone_Wolf croatian: 6 changes by VoyagerOne
2019-03-10Fix: [AzurePipelines] run commit checker only for PRsglx
2019-03-10Fix: [AzurePipelines] Run commit checker only for PRs and pass it the target ↵glx22
branch (#7356)
2019-03-10Feature: Add road icon to road construction drop down list.peter1138
2019-03-10Feature: Add rail icon to rail construction drop down list.peter1138
2019-03-10Add: Generic drop down list string item with icon.peter1138
2019-03-10Remove: Unnecessary virtual destructors on drop down list items.peter1138
2019-03-10Remove: Unnecessary specialization of NewGRF preset list item.peter1138
2019-03-10Codechange: Use Colours type instead of byte.peter1138
2019-03-10Feature: Railtype flags to allow/disallow 90 degree curves. (#7352)Michael Lutz
2019-03-10Fix e4cc06f67: [AzurePipelines] rebase only for PRsglx