diff options
Diffstat (limited to 'src/misc')
| -rw-r--r-- | src/misc/blob.hpp | 76 | ||||
| -rw-r--r-- | src/misc/dbg_helpers.h | 24 | ||||
| -rw-r--r-- | src/misc/strapi.hpp | 6 |
3 files changed, 53 insertions, 53 deletions
diff --git a/src/misc/blob.hpp b/src/misc/blob.hpp index d28f6f00d..6238cba3e 100644 --- a/src/misc/blob.hpp +++ b/src/misc/blob.hpp @@ -9,34 +9,34 @@ #include "../core/mem_func.hpp" /** Base class for simple binary blobs. -* Item is byte. -* The word 'simple' means: -* - no configurable allocator type (always made from heap) -* - no smart deallocation - deallocation must be called from the same -* module (DLL) where the blob was allocated -* - no configurable allocation policy (how big blocks should be allocated) -* - no extra ownership policy (i.e. 'copy on write') when blob is copied -* - no thread synchronization at all -* -* Internal member layout: -* 1. The only class member is pointer to the first item (see union ptr_u). -* 2. Allocated block contains the blob header (see CHdr) followed by the raw byte data. -* Always, when it allocates memory the allocated size is: -* sizeof(CHdr) + <data capacity> -* 3. Two 'virtual' members (m_size and m_max_size) are stored in the CHdr at beginning -* of the alloated block. -* 4. The pointter (in ptr_u) pobsize_ts behind the header (to the first data byte). -* When memory block is allocated, the sizeof(CHdr) it added to it. -* 5. Benefits of this layout: -* - items are accessed in the simplest possible way - just dereferencing the pointer, -* which is good for performance (assuming that data are accessed most often). -* - sizeof(blob) is the same as the size of any other pointer -* 6. Drawbacks of this layout: -* - the fact, that pointer to the alocated block is adjusted by sizeof(CHdr) before -* it is stored can lead to several confusions: -* - it is not common pattern so the implementation code is bit harder to read -* - valgrind can generate warning that allocated block is lost (not accessible) -* */ + * Item is byte. + * The word 'simple' means: + * - no configurable allocator type (always made from heap) + * - no smart deallocation - deallocation must be called from the same + * module (DLL) where the blob was allocated + * - no configurable allocation policy (how big blocks should be allocated) + * - no extra ownership policy (i.e. 'copy on write') when blob is copied + * - no thread synchronization at all + * + * Internal member layout: + * 1. The only class member is pointer to the first item (see union ptr_u). + * 2. Allocated block contains the blob header (see CHdr) followed by the raw byte data. + * Always, when it allocates memory the allocated size is: + * sizeof(CHdr) + <data capacity> + * 3. Two 'virtual' members (m_size and m_max_size) are stored in the CHdr at beginning + * of the alloated block. + * 4. The pointter (in ptr_u) pobsize_ts behind the header (to the first data byte). + * When memory block is allocated, the sizeof(CHdr) it added to it. + * 5. Benefits of this layout: + * - items are accessed in the simplest possible way - just dereferencing the pointer, + * which is good for performance (assuming that data are accessed most often). + * - sizeof(blob) is the same as the size of any other pointer + * 6. Drawbacks of this layout: + * - the fact, that pointer to the alocated block is adjusted by sizeof(CHdr) before + * it is stored can lead to several confusions: + * - it is not common pattern so the implementation code is bit harder to read + * - valgrind can generate warning that allocated block is lost (not accessible) + */ class CBlobBaseSimple { public: typedef ::ptrdiff_t bsize_t; @@ -93,7 +93,7 @@ public: protected: /** initialize the empty blob by setting the ptr_u.m_pHdr_1 pointer to the static CHdr with - * both m_size and m_max_size containing zero */ + * both m_size and m_max_size containing zero */ FORCEINLINE void InitEmpty() { static CHdr hdrEmpty[] = {{0, 0}, {0, 0}}; @@ -217,7 +217,7 @@ public: } /** Reallocate if there is no free space for num_bytes bytes. - * @return pointer to the new data to be added */ + * @return pointer to the new data to be added */ FORCEINLINE bitem_t *MakeRawFreeSpace(bsize_t num_bytes) { assert(num_bytes >= 0); @@ -227,7 +227,7 @@ public: } /** Increase RawSize() by num_bytes. - * @return pointer to the new data added */ + * @return pointer to the new data added */ FORCEINLINE bitem_t *GrowRawSize(bsize_t num_bytes) { bitem_t *pNewData = MakeRawFreeSpace(num_bytes); @@ -312,12 +312,12 @@ public: }; /** Blob - simple dynamic Titem_ array. Titem_ (template argument) is a placeholder for any type. -* Titem_ can be any integral type, pointer, or structure. Using Blob instead of just plain C array -* simplifies the resource management in several ways: -* 1. When adding new item(s) it automatically grows capacity if needed. -* 2. When variable of type Blob comes out of scope it automatically frees the data buffer. -* 3. Takes care about the actual data size (number of used items). -* 4. Dynamically constructs only used items (as opposite of static array which constructs all items) */ + * Titem_ can be any integral type, pointer, or structure. Using Blob instead of just plain C array + * simplifies the resource management in several ways: + * 1. When adding new item(s) it automatically grows capacity if needed. + * 2. When variable of type Blob comes out of scope it automatically frees the data buffer. + * 3. Takes care about the actual data size (number of used items). + * 4. Dynamically constructs only used items (as opposite of static array which constructs all items) */ template <class Titem_, class Tbase_ = CBlobBaseSimple> class CBlobT : public Tbase_ { // make template arguments public: @@ -504,7 +504,7 @@ public: } /** Ensures that given number of items can be added to the end of Blob. Returns pointer to the - * first free (unused) item */ + * first free (unused) item */ FORCEINLINE Titem *MakeFreeSpace(bsize_t num_items) { return (Titem*)Tbase::MakeRawFreeSpace(num_items * Titem_size); diff --git a/src/misc/dbg_helpers.h b/src/misc/dbg_helpers.h index 0cbb1c077..3816ac628 100644 --- a/src/misc/dbg_helpers.h +++ b/src/misc/dbg_helpers.h @@ -23,9 +23,9 @@ template <typename T, size_t N> struct ArrayT<T[N]> { /** -* Helper template function that returns item of array at given index -* or t_unk when index is out of bounds. -*/ + * Helper template function that returns item of array at given index + * or t_unk when index is out of bounds. + */ template <typename E, typename T> inline typename ArrayT<T>::item_t ItemAtT(E idx, T &t, typename ArrayT<T>::item_t t_unk) { @@ -36,10 +36,10 @@ inline typename ArrayT<T>::item_t ItemAtT(E idx, T &t, typename ArrayT<T>::item_ } /** -* Helper template function that returns item of array at given index -* or t_inv when index == idx_inv -* or t_unk when index is out of bounds. -*/ + * Helper template function that returns item of array at given index + * or t_inv when index == idx_inv + * or t_unk when index is out of bounds. + */ template <typename E, typename T> inline typename ArrayT<T>::item_t ItemAtT(E idx, T &t, typename ArrayT<T>::item_t t_unk, E idx_inv, typename ArrayT<T>::item_t t_inv) { @@ -53,11 +53,11 @@ inline typename ArrayT<T>::item_t ItemAtT(E idx, T &t, typename ArrayT<T>::item_ } /** -* Helper template function that returns compound bitfield name that is -* concatenation of names of each set bit in the given value -* or t_inv when index == idx_inv -* or t_unk when index is out of bounds. -*/ + * Helper template function that returns compound bitfield name that is + * concatenation of names of each set bit in the given value + * or t_inv when index == idx_inv + * or t_unk when index is out of bounds. + */ template <typename E, typename T> inline CStrA ComposeNameT(E value, T &t, const char *t_unk, E val_inv, const char *name_inv) { diff --git a/src/misc/strapi.hpp b/src/misc/strapi.hpp index eec7c6437..7fe48d098 100644 --- a/src/misc/strapi.hpp +++ b/src/misc/strapi.hpp @@ -17,9 +17,9 @@ #endif /* HAS_WCHAR */ /** String API mapper base - just mapping by character type, not by case sensitivity yet. - * Class template CStrApiBaseT declaration is general, but following inline method - * definitions are specialized by character type. Class is not used directly, but only - * as a base class for template class CStrApiT */ + * Class template CStrApiBaseT declaration is general, but following inline method + * definitions are specialized by character type. Class is not used directly, but only + * as a base class for template class CStrApiT */ template <typename Tchar> class CStrApiBaseT { |