summaryrefslogtreecommitdiff
path: root/train_gui.c
diff options
context:
space:
mode:
authorDarkvater <Darkvater@openttd.org>2006-10-21 23:31:34 +0000
committerDarkvater <Darkvater@openttd.org>2006-10-21 23:31:34 +0000
commit494c56475f04f0753d1ef7b8126612d3017df861 (patch)
treebbd2a7ac7e0c3b558bf638e1779108ced158cb6a /train_gui.c
parentc15e699479ca81045db05af98ad86452b97572fd (diff)
downloadopenttd-494c56475f04f0753d1ef7b8126612d3017df861.tar.xz
(svn r6884) -Codechange: Add strict bounds checking in string formatting system.
The last parameter should point to the end of the buffer (eg lastof(buf)) Courtesy of Tron.
Diffstat (limited to 'train_gui.c')
-rw-r--r--train_gui.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/train_gui.c b/train_gui.c
index fc02c6792..1c52d719b 100644
--- a/train_gui.c
+++ b/train_gui.c
@@ -135,13 +135,13 @@ static int CDECL TrainEngineNameSorter(const void *a, const void *b)
char buf1[64];
int r;
- GetString(buf1, GetCustomEngineName(va));
+ GetString(buf1, GetCustomEngineName(va), lastof(buf1));
if (vb != _last_engine) {
_last_engine = vb;
_bufcache[0] = '\0';
- GetString(_bufcache, GetCustomEngineName(vb));
+ GetString(_bufcache, GetCustomEngineName(vb), lastof(_bufcache));
}
r = strcasecmp(buf1, _bufcache); // sort by name