diff options
| author | Darkvater <darkvater@openttd.org> | 2006-10-21 23:31:34 +0000 |
|---|---|---|
| committer | Darkvater <darkvater@openttd.org> | 2006-10-21 23:31:34 +0000 |
| commit | ee27bb497c0790d86da6025fa48034f01f36d6e0 (patch) | |
| tree | bbd2a7ac7e0c3b558bf638e1779108ced158cb6a /town_gui.c | |
| parent | 7f36a980c70d2444a68af5046e47c0313d67b2ef (diff) | |
| download | openttd-ee27bb497c0790d86da6025fa48034f01f36d6e0.tar.xz | |
(svn r6884) -Codechange: Add strict bounds checking in string formatting system.
The last parameter should point to the end of the buffer (eg lastof(buf))
Courtesy of Tron.
Diffstat (limited to 'town_gui.c')
| -rw-r--r-- | town_gui.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/town_gui.c b/town_gui.c index e89b7da5f..52020ca10 100644 --- a/town_gui.c +++ b/town_gui.c @@ -378,7 +378,7 @@ static int CDECL TownNameSorter(const void *a, const void *b) int r; SetDParam(0, ta->index); - GetString(buf1, STR_TOWN); + GetString(buf1, STR_TOWN, lastof(buf1)); /* If 'b' is the same town as in the last round, use the cached value * We do this to speed stuff up ('b' is called with the same value a lot of @@ -386,7 +386,7 @@ static int CDECL TownNameSorter(const void *a, const void *b) if (tb != _last_town) { _last_town = tb; SetDParam(0, tb->index); - GetString(_bufcache, STR_TOWN); + GetString(_bufcache, STR_TOWN, lastof(_bufcache)); } r = strcmp(buf1, _bufcache); |