diff options
| author | Rubidium <rubidium@openttd.org> | 2021-05-09 22:51:26 +0200 |
|---|---|---|
| committer | rubidium42 <rubidium42@users.noreply.github.com> | 2021-05-10 16:03:31 +0200 |
| commit | 296194ad36c601cf12d215a65d84222bbdf4de61 (patch) | |
| tree | 99a0074d211257c2a5c29c40da75f23713eaf406 /src | |
| parent | 79fc094c54801bba83dc8aca2028fd6baf35965f (diff) | |
| download | openttd-296194ad36c601cf12d215a65d84222bbdf4de61.tar.xz | |
Fix: memory leak due to assigning result of strdup to a std::string
Diffstat (limited to 'src')
| -rw-r--r-- | src/newgrf.cpp | 2 | ||||
| -rw-r--r-- | src/signs_cmd.cpp | 2 | ||||
| -rw-r--r-- | src/town_cmd.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/newgrf.cpp b/src/newgrf.cpp index 7b8ab9de1..c372f033a 100644 --- a/src/newgrf.cpp +++ b/src/newgrf.cpp @@ -7394,7 +7394,7 @@ static void GRFInhibit(ByteReader *buf) if (file != nullptr && file != _cur.grfconfig) { grfmsg(2, "GRFInhibit: Deactivating file '%s'", file->filename); GRFError *error = DisableGrf(STR_NEWGRF_ERROR_FORCEFULLY_DISABLED, file); - error->data = stredup(_cur.grfconfig->GetName()); + error->data = _cur.grfconfig->GetName(); } } } diff --git a/src/signs_cmd.cpp b/src/signs_cmd.cpp index a0843917d..6ffb6cda1 100644 --- a/src/signs_cmd.cpp +++ b/src/signs_cmd.cpp @@ -54,7 +54,7 @@ CommandCost CmdPlaceSign(TileIndex tile, DoCommandFlag flags, uint32 p1, uint32 si->y = y; si->z = GetSlopePixelZ(x, y); if (!StrEmpty(text)) { - si->name = stredup(text); + si->name = text; } si->UpdateVirtCoord(); InvalidateWindowData(WC_SIGN_LIST, 0, 0); diff --git a/src/town_cmd.cpp b/src/town_cmd.cpp index 01331a269..033d04248 100644 --- a/src/town_cmd.cpp +++ b/src/town_cmd.cpp @@ -2004,7 +2004,7 @@ CommandCost CmdFoundTown(TileIndex tile, DoCommandFlag flags, uint32 p1, uint32 old_generating_world.Restore(); if (t != nullptr && !StrEmpty(text)) { - t->name = stredup(text); + t->name = text; t->UpdateVirtCoord(); } |