diff options
| author | Eddi-z <43699911+Eddi-z@users.noreply.github.com> | 2019-03-01 00:00:50 +0100 |
|---|---|---|
| committer | PeterN <peter@fuzzle.org> | 2019-02-28 23:00:50 +0000 |
| commit | 1447661d204570883cd1d463f2f08f81948d436e (patch) | |
| tree | c6300621323074c84123ec2ec30612a05d502626 /src | |
| parent | 9ad511262847c7137fdd7e3c811fea070ac0e72b (diff) | |
| download | openttd-1447661d204570883cd1d463f2f08f81948d436e.tar.xz | |
Cleanup: spurious TODOs in newgrf.cpp (#7297)
Diffstat (limited to 'src')
| -rw-r--r-- | src/newgrf.cpp | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/src/newgrf.cpp b/src/newgrf.cpp index 74d29e3e5..ff1028798 100644 --- a/src/newgrf.cpp +++ b/src/newgrf.cpp @@ -5828,7 +5828,6 @@ static void GraphicsNew(ByteReader *buf) * B graphics-type What set of graphics the sprites define. * E num-sprites How many sprites are in this set? * V other data Graphics type specific data. Currently unused. */ - /* TODO */ uint8 type = buf->ReadByte(); uint16 num = buf->ReadExtendedByte(); @@ -6216,7 +6215,6 @@ static void SkipIf(ByteReader *buf) * B condition-type * V value * B num-sprites */ - /* TODO: More params. More condition types. */ uint32 cond_val = 0; uint32 mask = 0; bool result; @@ -6902,12 +6900,6 @@ static void ParamSet(ByteReader *buf) src2 = (src2 == 0xFF) ? data : GetParamVal(src2, NULL); } - /* TODO: You can access the parameters of another GRF file by using - * source2=FE, source1=the other GRF's parameter number and data=GRF - * ID. This is only valid with operation 00 (set). If the GRF ID - * cannot be found, a value of 0 is used for the parameter value - * instead. */ - uint32 res; switch (oper) { case 0x00: @@ -7008,13 +7000,13 @@ static void ParamSet(ByteReader *buf) break; } - /* @todo implement */ - case 0x93: // Tile refresh offset to left + /* not implemented */ + case 0x93: // Tile refresh offset to left -- Intended to allow support for larger sprites, not necessary for OTTD case 0x94: // Tile refresh offset to right case 0x95: // Tile refresh offset upwards case 0x96: // Tile refresh offset downwards - case 0x97: // Snow line height - case 0x99: // Global ID offset + case 0x97: // Snow line height -- Better supported by feature 8 property 10h (snow line table) TODO: implement by filling the entire snow line table with the given value + case 0x99: // Global ID offset -- Not necessary since IDs are remapped automatically grfmsg(7, "ParamSet: Skipping unimplemented target 0x%02X", target); break; @@ -8237,7 +8229,6 @@ static void ResetNewGRFErrors() /** * Reset all NewGRF loaded data - * TODO */ void ResetNewGRFData() { |