summaryrefslogtreecommitdiff
path: root/src/viewport.cpp
diff options
context:
space:
mode:
authorpeter1138 <peter1138@openttd.org>2019-03-20 01:21:10 +0000
committerPeterN <peter@fuzzle.org>2019-03-20 23:00:32 +0000
commit4da83d2f661691b40eb53591d2a998596f5d16a0 (patch)
tree2e0910912bf2b08f8e713a4690a4bd11edfed2b8 /src/viewport.cpp
parente3c639a09f1d2251477f69496120d057dd8320a9 (diff)
downloadopenttd-4da83d2f661691b40eb53591d2a998596f5d16a0.tar.xz
Fix #7386: Measurement tooltip for tunnels, aqueducts & docks did not display or flickered.
Measurement tooltip was auto-closed as the hover/right-click test for tooltips was not satisfied in this case. This is fixed by keeping the tooltip visible and instead explicitly closing the tooltip when the PlaceObject is cancelled/completed.
Diffstat (limited to 'src/viewport.cpp')
-rw-r--r--src/viewport.cpp18
1 files changed, 15 insertions, 3 deletions
diff --git a/src/viewport.cpp b/src/viewport.cpp
index 8d9f4513e..729dfca7b 100644
--- a/src/viewport.cpp
+++ b/src/viewport.cpp
@@ -2508,12 +2508,17 @@ void UpdateTileSelection()
* @param params (optional) up to 5 pieces of additional information that may be added to a tooltip
* @param close_cond Condition for closing this tooltip.
*/
-static inline void ShowMeasurementTooltips(StringID str, uint paramcount, const uint64 params[], TooltipCloseCondition close_cond = TCC_LEFT_CLICK)
+static inline void ShowMeasurementTooltips(StringID str, uint paramcount, const uint64 params[], TooltipCloseCondition close_cond = TCC_NONE)
{
if (!_settings_client.gui.measure_tooltip) return;
GuiShowTooltips(_thd.GetCallbackWnd(), str, paramcount, params, close_cond);
}
+void HideMeasurementTooltips()
+{
+ DeleteWindowById(WC_TOOLTIPS, 0);
+}
+
/** highlighting tiles while only going over them with the mouse */
void VpStartPlaceSizing(TileIndex tile, ViewportPlaceMethod method, ViewportDragDropSelectionProcess process)
{
@@ -2569,7 +2574,11 @@ void VpSetPresizeRange(TileIndex from, TileIndex to)
_thd.next_drawstyle = HT_RECT;
/* show measurement only if there is any length to speak of */
- if (distance > 1) ShowMeasurementTooltips(STR_MEASURE_LENGTH, 1, &distance, TCC_HOVER);
+ if (distance > 1) {
+ ShowMeasurementTooltips(STR_MEASURE_LENGTH, 1, &distance);
+ } else {
+ HideMeasurementTooltips();
+ }
}
static void VpStartPreSizing()
@@ -3221,7 +3230,10 @@ void SetObjectToPlace(CursorID icon, PaletteID pal, HighLightStyle mode, WindowC
* this function might in some cases reset the newly set object to
* place or not properly reset the original selection. */
_thd.window_class = WC_INVALID;
- if (w != NULL) w->OnPlaceObjectAbort();
+ if (w != NULL) {
+ w->OnPlaceObjectAbort();
+ HideMeasurementTooltips();
+ }
}
/* Mark the old selection dirty, in case the selection shape or colour changes */