summaryrefslogtreecommitdiff
path: root/src/video
diff options
context:
space:
mode:
authorMichael Lutz <michi@icosahedron.de>2021-02-06 01:51:38 +0100
committerMichael Lutz <michi@icosahedron.de>2021-02-13 22:21:17 +0100
commit60f30036f1338b6fba8a0c23d7a8b70eab697644 (patch)
tree37db838aceccab3bee7aca82a6e5a462a1e6b803 /src/video
parent8aaf4ea0987a361e5d4f7b690544ee9119746660 (diff)
downloadopenttd-60f30036f1338b6fba8a0c23d7a8b70eab697644.tar.xz
Codechange: [OSX] Drain autoreleased objects in each game loop cycle.
Diffstat (limited to 'src/video')
-rw-r--r--src/video/cocoa/cocoa_wnd.mm19
-rw-r--r--src/video/cocoa/event.mm73
2 files changed, 49 insertions, 43 deletions
diff --git a/src/video/cocoa/cocoa_wnd.mm b/src/video/cocoa/cocoa_wnd.mm
index 80c2e2e21..e7c916443 100644
--- a/src/video/cocoa/cocoa_wnd.mm
+++ b/src/video/cocoa/cocoa_wnd.mm
@@ -203,6 +203,7 @@ bool CocoaSetupApplication()
}
/* Become the front process, important when start from the command line. */
+ [ [ NSApplication sharedApplication ] setActivationPolicy:NSApplicationActivationPolicyRegular ];
[ [ NSApplication sharedApplication ] activateIgnoringOtherApps:YES ];
/* Set up the menubar */
@@ -247,15 +248,17 @@ void CocoaDialog(const char *title, const char *message, const char *buttonLabel
return;
}
- NSAlert *alert = [ [ NSAlert alloc ] init ];
- [ alert setAlertStyle: NSCriticalAlertStyle ];
- [ alert setMessageText:[ NSString stringWithUTF8String:title ] ];
- [ alert setInformativeText:[ NSString stringWithUTF8String:message ] ];
- [ alert addButtonWithTitle: [ NSString stringWithUTF8String:buttonLabel ] ];
- [ alert runModal ];
- [ alert release ];
+ @autoreleasepool {
+ NSAlert *alert = [ [ NSAlert alloc ] init ];
+ [ alert setAlertStyle: NSCriticalAlertStyle ];
+ [ alert setMessageText:[ NSString stringWithUTF8String:title ] ];
+ [ alert setInformativeText:[ NSString stringWithUTF8String:message ] ];
+ [ alert addButtonWithTitle: [ NSString stringWithUTF8String:buttonLabel ] ];
+ [ alert runModal ];
+ [ alert release ];
+ }
- if (!wasstarted && VideoDriver::GetInstance() != NULL) VideoDriver::GetInstance()->Stop();
+ if (!wasstarted && VideoDriver::GetInstance() != nullptr) VideoDriver::GetInstance()->Stop();
_cocoa_video_dialog = false;
}
diff --git a/src/video/cocoa/event.mm b/src/video/cocoa/event.mm
index 858cd51ad..00559e6bc 100644
--- a/src/video/cocoa/event.mm
+++ b/src/video/cocoa/event.mm
@@ -609,57 +609,60 @@ void VideoDriver_Cocoa::GameLoop()
this->Draw(true);
for (;;) {
- uint32 prev_cur_ticks = cur_ticks; // to check for wrapping
- InteractiveRandom(); // randomness
+ @autoreleasepool {
- while (this->PollEvent()) {}
+ uint32 prev_cur_ticks = cur_ticks; // to check for wrapping
+ InteractiveRandom(); // randomness
- if (_exit_game) {
- /* Restore saved resolution if in fullscreen mode. */
- if (this->IsFullscreen()) _cur_resolution = this->orig_res;
- break;
- }
+ while (this->PollEvent()) {}
+
+ if (_exit_game) {
+ /* Restore saved resolution if in fullscreen mode. */
+ if (this->IsFullscreen()) _cur_resolution = this->orig_res;
+ break;
+ }
#if defined(_DEBUG)
- if (_current_mods & NSShiftKeyMask)
+ if (_current_mods & NSShiftKeyMask)
#else
- if (_tab_is_down)
+ if (_tab_is_down)
#endif
- {
- if (!_networking && _game_mode != GM_MENU) _fast_forward |= 2;
- } else if (_fast_forward & 2) {
- _fast_forward = 0;
- }
+ {
+ if (!_networking && _game_mode != GM_MENU) _fast_forward |= 2;
+ } else if (_fast_forward & 2) {
+ _fast_forward = 0;
+ }
- cur_ticks = GetTick();
- if (cur_ticks >= next_tick || (_fast_forward && !_pause_mode) || cur_ticks < prev_cur_ticks) {
- _realtime_tick += cur_ticks - last_cur_ticks;
- last_cur_ticks = cur_ticks;
- next_tick = cur_ticks + MILLISECONDS_PER_TICK;
+ cur_ticks = GetTick();
+ if (cur_ticks >= next_tick || (_fast_forward && !_pause_mode) || cur_ticks < prev_cur_ticks) {
+ _realtime_tick += cur_ticks - last_cur_ticks;
+ last_cur_ticks = cur_ticks;
+ next_tick = cur_ticks + MILLISECONDS_PER_TICK;
- bool old_ctrl_pressed = _ctrl_pressed;
+ bool old_ctrl_pressed = _ctrl_pressed;
- _ctrl_pressed = !!(_current_mods & ( _settings_client.gui.right_mouse_btn_emulation != RMBE_CONTROL ? NSControlKeyMask : NSCommandKeyMask));
- _shift_pressed = !!(_current_mods & NSShiftKeyMask);
+ _ctrl_pressed = !!(_current_mods & ( _settings_client.gui.right_mouse_btn_emulation != RMBE_CONTROL ? NSControlKeyMask : NSCommandKeyMask));
+ _shift_pressed = !!(_current_mods & NSShiftKeyMask);
- if (old_ctrl_pressed != _ctrl_pressed) HandleCtrlChanged();
+ if (old_ctrl_pressed != _ctrl_pressed) HandleCtrlChanged();
- ::GameLoop();
+ ::GameLoop();
- UpdateWindows();
- this->CheckPaletteAnim();
- this->Draw();
- } else {
+ UpdateWindows();
+ this->CheckPaletteAnim();
+ this->Draw();
+ } else {
#ifdef _DEBUG
- uint32 st0 = GetTick();
+ uint32 st0 = GetTick();
#endif
- CSleep(1);
+ CSleep(1);
#ifdef _DEBUG
- st += GetTick() - st0;
+ st += GetTick() - st0;
#endif
- NetworkDrawChatMessage();
- DrawMouseCursor();
- this->Draw();
+ NetworkDrawChatMessage();
+ DrawMouseCursor();
+ this->Draw();
+ }
}
}