summaryrefslogtreecommitdiff
path: root/src/network/network_internal.h
diff options
context:
space:
mode:
authorPatric Stout <truebrain@openttd.org>2021-04-27 20:18:43 +0200
committerGitHub <noreply@github.com>2021-04-27 20:18:43 +0200
commit8fa53f543a5929bdbb12c8776ae9577594f9eba7 (patch)
treed5a06916b0281b45ddee6323dbab0b7f5ee6d861 /src/network/network_internal.h
parent015e3b412ebe709e1596179e86fde364cf19f52a (diff)
downloadopenttd-8fa53f543a5929bdbb12c8776ae9577594f9eba7.tar.xz
Change: [Network] lower TCP connect() timeout to 3s (#9112)
Currently we use default OS timeout for TCP connections, which is around 30s. 99% of the users will never notice this, but there are a few cases where this is an issue: - If you have a broken IPv6 connection, using Content Service is first tried over IPv6. Only after 30s it times out and tries IPv4. Nobody is waiting for that 30s. - Upcoming STUN support has several methods of establishing a connection between client and server. This requires feedback from connect() to know if any method worked (they have to be tried one by one). With 30s, this would take a very long time. What is good to mention, is that there is no good value here. Any value will have edge-cases where the experience is suboptimal. But with 3s we support most of the stable connections, and if it fails, the user can just retry. On the other side of the spectrum, with 30s, it means the user has no possibility to use the service. So worst case we annoy a few users with them having the retry vs annoying a few users which have no means of resolving the situation.
Diffstat (limited to 'src/network/network_internal.h')
0 files changed, 0 insertions, 0 deletions