summaryrefslogtreecommitdiff
path: root/src/network/core
diff options
context:
space:
mode:
authorHenry Wilson <m3henry@googlemail.com>2018-09-23 22:15:35 +0100
committerPeterN <peter@fuzzle.org>2019-03-26 20:15:57 +0000
commit846095224044b39ddd3249b6ea072e486ba1fe38 (patch)
treeae8a22887b9b5f8fc8b4a7695826af739c3cc2de /src/network/core
parent81315939b909a95277ffbab51709714779089656 (diff)
downloadopenttd-846095224044b39ddd3249b6ea072e486ba1fe38.tar.xz
Codechange: Replaced SmallVector::Find() const with suitable alternatives
The use of std::none_of in network/core/host.cpp is driven by the non-const comparison operator use by NetworkAddress. A future commit should address the const_casts in that class to ensure const-correctness.
Diffstat (limited to 'src/network/core')
-rw-r--r--src/network/core/host.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/network/core/host.cpp b/src/network/core/host.cpp
index 05ad84153..c0365742b 100644
--- a/src/network/core/host.cpp
+++ b/src/network/core/host.cpp
@@ -76,7 +76,7 @@ static void NetworkFindBroadcastIPsInternal(NetworkAddressList *broadcast) // BE
memset(&address, 0, sizeof(address));
((sockaddr_in*)&address)->sin_addr.s_addr = htonl(ip | ~netmask);
NetworkAddress addr(address, sizeof(sockaddr));
- if (!broadcast->Contains(addr)) *broadcast->Append() = addr;
+ if (std::none_of(broadcast->begin(), broadcast->end(), [&addr](NetworkAddress const& elem) -> bool { return elem == addr; })) *broadcast->Append() = addr;
}
if (read < 0) {
break;
@@ -100,7 +100,7 @@ static void NetworkFindBroadcastIPsInternal(NetworkAddressList *broadcast) // GE
if (ifa->ifa_broadaddr->sa_family != AF_INET) continue;
NetworkAddress addr(ifa->ifa_broadaddr, sizeof(sockaddr));
- if (!broadcast->Contains(addr)) *broadcast->Append() = addr;
+ if (std::none_of(broadcast->begin(), broadcast->end(), [&addr](NetworkAddress const& elem) -> bool { return elem == addr; })) *broadcast->Append() = addr;
}
freeifaddrs(ifap);
}
@@ -136,7 +136,7 @@ static void NetworkFindBroadcastIPsInternal(NetworkAddressList *broadcast) // Wi
memcpy(&address, &ifo[j].iiAddress.Address, sizeof(sockaddr));
((sockaddr_in*)&address)->sin_addr.s_addr = ifo[j].iiAddress.AddressIn.sin_addr.s_addr | ~ifo[j].iiNetmask.AddressIn.sin_addr.s_addr;
NetworkAddress addr(address, sizeof(sockaddr));
- if (!broadcast->Contains(addr)) *broadcast->Append() = addr;
+ if (std::none_of(broadcast->begin(), broadcast->end(), [&addr](NetworkAddress const& elem) -> bool { return elem == addr; })) *broadcast->Append() = addr;
}
free(ifo);
@@ -174,7 +174,7 @@ static void NetworkFindBroadcastIPsInternal(NetworkAddressList *broadcast) // !G
(r.ifr_flags & IFF_BROADCAST) &&
ioctl(sock, SIOCGIFBRDADDR, &r) != -1) {
NetworkAddress addr(&r.ifr_broadaddr, sizeof(sockaddr));
- if (!broadcast->Contains(addr)) *broadcast->Append() = addr;
+ if (std::none_of(broadcast->begin(), broadcast->end(), [&addr](NetworkAddress const& elem) -> bool { return elem == addr; })) *broadcast->Append() = addr;
}
}