(svn r6696) -Codechange: changed all comparision for refit cargo in orders against CT_NO_REFIT to checks for valid cargo IDs

  This should prevent any bugs made by mixing up CT_NO_REFIT and CT_INVALID

1 files changed, 3 insertions, 3 deletions

diff --git a/order_gui.c b/order_gui.c
index 532005da1..bf53ff958 100644
--- a/order_gui.c
+++ b/order_gui.c
@@ -170,11 +170,11 @@ static void DrawOrdersWindow(Window *w)
 					if (order->flags & OF_FULL_LOAD) s++; /* service at */
 
 					SetDParam(1, s);
-					if (order->refit_cargo == CT_NO_REFIT) {
-						SetDParam(3, STR_EMPTY);
-					} else {
+					if (order->refit_cargo < NUM_CARGO) {
 						SetDParam(3, STR_REFIT_ORDER);
 						SetDParam(4, _cargoc.names_s[order->refit_cargo]);
+					} else {
+						SetDParam(3, STR_EMPTY);
 					}
 					break;
 				}