diff options
| author | Niels Martin Hansen <nielsm@indvikleren.dk> | 2018-07-01 12:15:00 +0200 |
|---|---|---|
| committer | Michael Lutz <michi@icosahedron.de> | 2018-07-01 12:15:00 +0200 |
| commit | 6cf4d7d3ef4dd27eac482eed86a3de1504454dbe (patch) | |
| tree | d3833dbc65576f8f9a4cceaee2a4c23e57550fd2 | |
| parent | 4189cb85ba054d0f41ec0b64a9323e63e49f2afc (diff) | |
| download | openttd-6cf4d7d3ef4dd27eac482eed86a3de1504454dbe.tar.xz | |
Fix: Put last SVN revision back in NewGRF version number (#6843)
This is necessary to be compatible with some Game Scripts that might trigger compatibility modes if the SVN revision part is wrong. Potentially some NewGRFs might also be affected.
See for example [SuperLib's Helper class](https://dev.openttdcoop.org/projects/superlib/repository/entry/helper.nut#L280), containing this function:
function _SuperLib_Helper::HasWorldGenBug()
{
local version = _SuperLib_Helper.GetOpenTTDVersion();
if (version.Major == 0 || (version.Major == 1 && version.Minor <= 3)) {
return version.Revision < 25339;
} else {
return version.Revision < 25305;
}
}
If this function sees a Revision value of zero, it might trigger a workaround not required, causing a regression in scripts dependent on this. The MinimalGS example, for one, will trigger this.
| -rw-r--r-- | src/rev.cpp.in | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/rev.cpp.in b/src/rev.cpp.in index 6689fe689..0f4b2a6b5 100644 --- a/src/rev.cpp.in +++ b/src/rev.cpp.in @@ -64,13 +64,13 @@ const byte _openttd_revision_modified = !!MODIFIED!!; * 24-27 minor version * 20-23 build * 19 1 if it is a release, 0 if it is not. - * 0-18 used to be the SVN revision, currently unused + * 0-18 used to be the SVN revision, now just last revision before switch to git * * The 19th bit is there so the development/betas/alpha, etc. leading to a * final release will always have a lower version number than the released * version, thus making comparisons on specific revisions easy. */ -const uint32 _openttd_newgrf_version = 1 << 28 | 9 << 24 | 0 << 20 | 0 << 19; +const uint32 _openttd_newgrf_version = 1 << 28 | 9 << 24 | 0 << 20 | 0 << 19 | 28004; #ifdef __MORPHOS__ /** |