diff options
author | rubidium <rubidium@openttd.org> | 2008-05-04 22:13:47 +0000 |
---|---|---|
committer | rubidium <rubidium@openttd.org> | 2008-05-04 22:13:47 +0000 |
commit | a89f533e095e3cbb4f0d85540734c0285bdca3aa (patch) | |
tree | 4857db07ae4e064b111ce01949e88748512f3da4 | |
parent | 89a8dc8cf7dd41a7c252dd91fc9c323651cfc95d (diff) | |
download | openttd-a89f533e095e3cbb4f0d85540734c0285bdca3aa.tar.xz |
(svn r12945) -Fix: (small) memory leak when joining/exiting threads.
-rw-r--r-- | src/thread_pthread.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/thread_pthread.cpp b/src/thread_pthread.cpp index 4645e4027..07d5e39b2 100644 --- a/src/thread_pthread.cpp +++ b/src/thread_pthread.cpp @@ -104,6 +104,8 @@ public: pthread_join(m_thr, &ret); m_thr = 0; + delete this; + return ret; } @@ -136,16 +138,22 @@ private: /* The new thread stops here so the calling thread can complete pthread_create() call */ sem_wait(&m_sem_start); + /* Did this thread die naturally/via exit, or did it join? */ + bool exit = false; + /* Call the proc of the creator to continue this thread */ try { m_proc(m_param); } catch (...) { + exit = true; } /* Notify threads waiting for our completion */ sem_post(&m_sem_stop); - return NULL; + if (exit) delete this; + + pthread_exit(NULL); } }; |