summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrubidium <rubidium@openttd.org>2008-10-14 18:49:21 +0000
committerrubidium <rubidium@openttd.org>2008-10-14 18:49:21 +0000
commit0c5c199f2fdf0441b1b790904838540dd5928ec0 (patch)
treeb2d954b54e588819ab760328365eee0b50bf4d11
parent272b2ef0e9072c6bf2ee3083c3673ae7773462ab (diff)
downloadopenttd-0c5c199f2fdf0441b1b790904838540dd5928ec0.tar.xz
(svn r14465) -Codechange: minor code style of command.cpp.
-rw-r--r--src/command.cpp12
1 files changed, 5 insertions, 7 deletions
diff --git a/src/command.cpp b/src/command.cpp
index 4ed4b3d6e..3c5f434c9 100644
--- a/src/command.cpp
+++ b/src/command.cpp
@@ -349,7 +349,7 @@ static const Command _command_proc_table[] = {
* @param cmd The integervalue of a command
* @return true if the command is valid (and got a CommandProc function)
*/
-bool IsValidCommand(uint cmd)
+bool IsValidCommand(uint32 cmd)
{
cmd &= 0xFF;
@@ -364,12 +364,11 @@ bool IsValidCommand(uint cmd)
*
* @param cmd The integer value of the command
* @return The flags for this command
- * @bug integervalues which are less equals 0xFF and greater than the
- * size of _command_proc_table can result in an index out of bounce
- * error (which doesn't happend anyway). Check function #IsValidCommand(). (Progman)
*/
-byte GetCommandFlags(uint cmd)
+byte GetCommandFlags(uint32 cmd)
{
+ assert(IsValidCommand(cmd));
+
return _command_proc_table[cmd & 0xFF].flags;
}
@@ -389,7 +388,6 @@ static int _docommand_recursive = 0;
CommandCost DoCommand(TileIndex tile, uint32 p1, uint32 p2, uint32 flags, uint32 procc)
{
CommandCost res;
- CommandProc *proc;
/* Do not even think about executing out-of-bounds tile-commands */
if (!IsValidTile(tile)) {
@@ -397,7 +395,7 @@ CommandCost DoCommand(TileIndex tile, uint32 p1, uint32 p2, uint32 flags, uint32
return CMD_ERROR;
}
- proc = _command_proc_table[procc].proc;
+ CommandProc *proc = _command_proc_table[procc].proc;
if (_docommand_recursive == 0) _error_message = INVALID_STRING_ID;