summaryrefslogtreecommitdiff
path: root/.github/workflows
diff options
context:
space:
mode:
authorPatric Stout <truebrain@openttd.org>2021-02-05 23:56:44 +0100
committerGitHub <noreply@github.com>2021-02-05 23:56:44 +0100
commit4f0692c437c7c89b38134255a5b7aea9f0378c19 (patch)
treeddf66cb84aefe6a154fd31794638e9e0e4d8ac9e /.github/workflows
parent99448eedca8f3759b8de44c356f3947dbd6e448b (diff)
downloadopenttd-4f0692c437c7c89b38134255a5b7aea9f0378c19.tar.xz
Codechange: [Actions] Document better why we build our own fluidsynth (#8646)
nielsmh nicely correct us in #8641, pointing out the old comment is not telling a complete truth. The result is the same, but it is better to not mislead future-us.
Diffstat (limited to '.github/workflows')
-rw-r--r--.github/workflows/release.yml12
1 files changed, 7 insertions, 5 deletions
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index d759d10e3..63af9ff87 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -301,11 +301,13 @@ jobs:
# EOF
echo "::endgroup::"
- # The yum variant of fluidsynth depends on all possible audio drivers.
- # This is not really useful for us, as that would require a user to
- # have them all before he can start OpenTTD. Instead, compile a
- # version that can only use SDL2. As OpenTTD does sound via SDL2,
- # this simply means we either have sound and music, or have none.
+ # The yum variant of fluidsynth depends on all possible audio drivers,
+ # like jack, ALSA, pulseaudio, etc. This is not really useful for us,
+ # as we route the output of fluidsynth back via our sound driver, and
+ # as such do not use these audio driver outputs at all. So instead,
+ # we compile fluidsynth ourselves, with as little dependencies as
+ # possible. This currently means it picks up SDL2, but this is fine,
+ # as we need SDL2 anyway.
echo "::group::Install fluidsynth"
wget https://github.com/FluidSynth/fluidsynth/archive/v2.1.6.tar.gz
tar xf v2.1.6.tar.gz