diff options
| author | Luke Shumaker <lukeshu@parabola.nu> | 2017-05-05 18:41:05 -0400 |
|---|---|---|
| committer | Erich Eckner <git@eckner.net> | 2017-07-14 06:54:28 +0200 |
| commit | 7494a6d3e615ea601c2a5dc5b45ceed18ceda2b6 (patch) | |
| tree | 714280081e6b1513bf066aa0a8356eda7c5b5b9f /makechrootpkg.in | |
| parent | 5a916f3b9bea81d6461ad5543a1c77bc81da72ff (diff) | |
| download | devtools-7494a6d3e615ea601c2a5dc5b45ceed18ceda2b6.tar.xz | |
makechrootpkg: Add a comment warning about a bug in "sudo -i"
The bug isn't currently triggered, but I accidentally did trigger when I
was trying to modify the command a bit. I figure a "caution" sign would be
helpful to any future developers.
Diffstat (limited to 'makechrootpkg.in')
| -rw-r--r-- | makechrootpkg.in | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/makechrootpkg.in b/makechrootpkg.in index 3b38ad2..4b6e129 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -242,6 +242,10 @@ EOF # so no global variables _chrootbuild() { . /etc/profile + # Beware, there are some stupid arbitrary rules on how you can + # use "$" in arguments to commands with "sudo -i". ${foo} or + # ${1} is OK, but $foo or $1 isn't. + # https://bugzilla.sudo.ws/show_bug.cgi?id=765 sudo -iu builduser bash -c 'cd /startdir; makepkg "$@"' -bash "$@" } |