diff options
author | Luke Shumaker <lukeshu@parabola.nu> | 2017-05-05 18:41:09 -0400 |
---|---|---|
committer | Jan Alexander Steffens (heftig) <jan.steffens@gmail.com> | 2017-07-05 18:21:56 +0200 |
commit | a396a6908110a860a89a1e640153bac1e0da2a57 (patch) | |
tree | d568adf0637e0247173ccefddf391bb23e4fc7f5 /commitpkg.in | |
parent | 78fabcfa0694ae8c81e1d5ec0e5dacaed533545e (diff) | |
download | devtools-a396a6908110a860a89a1e640153bac1e0da2a57.tar.xz |
Make slightly more involved changes to make shellcheck happy.
- Use `read -r` instead of other forms of read or looping
- Use arrays instead of strings with whitespaces.
- In one instance, use ${var%%.*} instead of $(echo $var|cut -f. -d1)
Diffstat (limited to 'commitpkg.in')
-rw-r--r-- | commitpkg.in | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/commitpkg.in b/commitpkg.in index 0482170..90210e5 100644 --- a/commitpkg.in +++ b/commitpkg.in @@ -148,9 +148,9 @@ for _arch in "${arch[@]}"; do if [[ ! -f $sigfile ]]; then msg "Signing package %s..." "${pkgfile}" if [[ -n $GPGKEY ]]; then - SIGNWITHKEY="-u ${GPGKEY}" + SIGNWITHKEY=(-u "${GPGKEY}") fi - gpg --detach-sign --use-agent --no-armor ${SIGNWITHKEY} "${pkgfile}" || die + gpg --detach-sign --use-agent --no-armor "${SIGNWITHKEY[@]}" "${pkgfile}" || die fi if ! gpg --verify "$sigfile" >/dev/null 2>&1; then die "Signature %s.sig is incorrect!" "$pkgfile" |