diff options
| author | Luke Shumaker <lukeshu@parabola.nu> | 2017-05-05 18:41:09 -0400 |
|---|---|---|
| committer | Erich Eckner <git@eckner.net> | 2017-07-14 06:58:26 +0200 |
| commit | 196cdd7ae6626e8c66336b6121c9024b70acea9c (patch) | |
| tree | 0cb8d448be851f21f8a197231f63e6d12240d3f8 /archrelease.in | |
| parent | c440e6f1c531688668ae25924f85cc45980f8295 (diff) | |
| download | devtools-196cdd7ae6626e8c66336b6121c9024b70acea9c.tar.xz | |
Make slightly more involved changes to make shellcheck happy.
- Use `read -r` instead of other forms of read or looping
- Use arrays instead of strings with whitespaces.
- In one instance, use ${var%%.*} instead of $(echo $var|cut -f. -d1)
Diffstat (limited to 'archrelease.in')
| -rw-r--r-- | archrelease.in | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/archrelease.in b/archrelease.in index 2ba9d48..6b4f1be 100644 --- a/archrelease.in +++ b/archrelease.in @@ -38,7 +38,7 @@ trunk=${PWD##*/} # Normally this should be trunk, but it may be something # such as 'gnome-unstable' IFS='/' read -r -d '' -a parts <<< "$PWD" -if [[ "${parts[@]:(-2):1}" == "repos" ]]; then +if [[ "${parts[*]:(-2):1}" == "repos" ]]; then die 'archrelease: Should not be in repos dir (try from trunk/)' fi unset parts @@ -67,7 +67,7 @@ for tag in "$@"; do while read -r file; do trash+=("repos/$tag/$file") done < <(svn ls "repos/$tag") - [[ $trash ]] && svn rm -q "${trash[@]/%/@}" + [[ ${#trash[@]} == 0 ]] || svn rm -q "${trash[@]/%/@}" else mkdir -p "repos/$tag" svn add --parents -q "repos/$tag" |