diff options
author | Eric Bélanger <snowmaniscool@gmail.com> | 2011-06-23 19:45:38 -0400 |
---|---|---|
committer | Pierre Schmitz <pierre@archlinux.de> | 2011-07-25 17:53:02 +0200 |
commit | 3040951ca09337bcfcc138f631d1a842bc8ea21f (patch) | |
tree | 8c31b6b6b4e1ac3604db2ca51d0a208d1eaaba89 | |
parent | 5d39ffb3414f1d4d13ae73ba5dbefa957c92dfe6 (diff) | |
download | devtools-3040951ca09337bcfcc138f631d1a842bc8ea21f.tar.xz |
Replace backticks by $() and add missing quotes
Signed-off-by: Eric Bélanger <snowmaniscool@gmail.com>
Signed-off-by: Pierre Schmitz <pierre@archlinux.de>
-rwxr-xr-x | checkpkg | 18 | ||||
-rwxr-xr-x | lddd | 4 |
2 files changed, 11 insertions, 11 deletions
@@ -47,16 +47,16 @@ for _pkgname in ${pkgname[@]}; do exit 1 fi - tmp=`pacman -Spdd --noconfirm $_pkgname` + tmp=$(pacman -Spdd --noconfirm $_pkgname) if [ $? -ne 0 ]; then echo "Couldn't download previous package for $_pkgname." exit 1 fi - pkgurl=`echo $tmp | rev | cut -d ' ' -f 1 | rev` + pkgurl=$(echo $tmp | rev | cut -d ' ' -f 1 | rev) - oldpkg=`strip_url $pkgurl` + oldpkg=$(strip_url $pkgurl) if [ "$(basename $oldpkg)" = "$(basename $pkgfile)" ]; then echo "The built package ($_pkgname) is the one in the repo right now!" @@ -65,11 +65,11 @@ for _pkgname in ${pkgname[@]}; do if [ ! -f $oldpkg ]; then if echo $pkgurl | grep '^file:///' > /dev/null 2>&1; then - cp `echo $pkgurl | sed 's#^file://##'` . - elif [ -f $PKGDEST/$oldpkg ]; then - cp $PKGDEST/$oldpkg . - elif [ -f $STARTDIR/$oldpkg ]; then - cp $STARTDIR/$oldpkg . + cp $(echo $pkgurl | sed 's#^file://##') . + elif [ -f "$PKGDEST/$oldpkg" ]; then + cp "$PKGDEST/$oldpkg" . + elif [ -f "$STARTDIR/$oldpkg" ]; then + cp "$STARTDIR/$oldpkg" . else wget --quiet $pkgurl fi @@ -87,7 +87,7 @@ for _pkgname in ${pkgname[@]}; do mkdir -p pkg cd pkg bsdtar xf ../"$pkgfile" > /dev/null - for i in `diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep \.so | awk '{print $2}'`; do + for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep \.so | awk '{print $2}'); do echo -n "${i}: " objdump -p $i | grep SONAME done @@ -25,9 +25,9 @@ for tree in $PATH $libdirs $extras; do -name '*.mcopclass' ! -name '*.mcoptype') IFS=$ifs for i in $files; do - if [ `file $i | grep -c 'ELF'` -ne 0 ]; then + if [ $(file $i | grep -c 'ELF') -ne 0 ]; then # Is an ELF binary. - if [ `ldd $i 2>/dev/null | grep -c 'not found'` -ne 0 ]; then + if [ $(ldd $i 2>/dev/null | grep -c 'not found') -ne 0 ]; then # Missing lib. echo "$i:" >> $TEMPDIR/raw.txt ldd $i 2>/dev/null | grep 'not found' >> $TEMPDIR/raw.txt |