diff options
author | Eli Schwartz <eschwartz@archlinux.org> | 2019-02-13 02:02:40 -0500 |
---|---|---|
committer | Levente Polyak <anthraxx@archlinux.org> | 2019-08-09 19:41:51 +0200 |
commit | df0d6b867b289ed98c4b9e7ced817dee155feb4f (patch) | |
tree | c2082ed57184ea3d5fb56a7201cc212c5606113a /.travis.yml | |
parent | 8f5a02b23ddb2491c13553cb71276bdd088f63ac (diff) | |
download | devtools-df0d6b867b289ed98c4b9e7ced817dee155feb4f.tar.xz |
Revert "makechrootpkg: Avoid having code floating around outside of a function."
This reverts commit 49088b0860276c664933c2b3e36a2fef714b7a07.
The fundamental intention was flawed and broken, it caused annoying
issues and regressions, and the self-avowed sole purpose of the change
was so that a downstream project could *post-modify the script and
source it as a library*.
That is not okay. You don't wrap non-factorable code in a function
called main() and call it a library. The only possible use for this is
to treat makechrootpkg *internals* as a library, which is not supported.
Downstream projects that wish to use the functionality of makechrootpkg
should treat makepkg as a command with a public API in the form of
command line options. That is kind of how commands of all kinds work,
since forever. That is how all users of makechrootpkg *except for
parabola* use it.
Arguments that "it saves us the cost of fork+exec to bash" are simply
invalid.
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Levente Polyak <anthraxx@archlinux.org>
Diffstat (limited to '.travis.yml')
0 files changed, 0 insertions, 0 deletions