From e4feb5c03bb4122344050efe75325d432db5791c Mon Sep 17 00:00:00 2001 From: Pádraig Brady
Date: Mon, 13 Jun 2011 11:33:10 +0100 Subject: tests: avoid a false failure on HPUX systems * tests/dd/nocache: Relax the test, as the system may return various errors from posix_fadvise(). HPUX 11.31 returns ENOTTY for example. Reported by Bruno Haible --- tests/dd/nocache | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'tests') diff --git a/tests/dd/nocache b/tests/dd/nocache index b5afabd35..0af165dc9 100755 --- a/tests/dd/nocache +++ b/tests/dd/nocache @@ -36,12 +36,12 @@ done # Advise to drop cache for whole file if ! dd if=ifile iflag=nocache count=0 2>err; then - if grep -F 'Operation not supported' err >/dev/null; then - warn_ 'skipping part; this file system lacks support for posix_fadvise()' - skip=1 - else - fail=1 - fi + # We could check for 'Operation not supported' in err here, + # but that was seen to be brittle. HPUX returns ENOTTY for example. + # So assume that if this basic operation fails, it's due to lack + # of support by the system. + warn_ 'skipping part; this file system lacks support for posix_fadvise()' + skip=1 fi if test "$skip" != 1; then -- cgit v1.2.3-70-g09d2