From b29db6767612cf70e9d4c7eb6ede9822f6173fca Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 13 Feb 2012 12:52:19 +0100 Subject: tests: test for ls speed-up * tests/ls/getxattr-speedup: New test. * tests/Makefile.am (TESTS): Add it. Improved-by: Bernhard Voelker --- tests/Makefile.am | 1 + tests/ls/getxattr-speedup | 64 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 65 insertions(+) create mode 100755 tests/ls/getxattr-speedup (limited to 'tests') diff --git a/tests/Makefile.am b/tests/Makefile.am index eed6ed624..2fee97d18 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -427,6 +427,7 @@ TESTS = \ ls/dired \ ls/file-type \ ls/follow-slink \ + ls/getxattr-speedup \ ls/infloop \ ls/inode \ ls/m-option \ diff --git a/tests/ls/getxattr-speedup b/tests/ls/getxattr-speedup new file mode 100755 index 000000000..2b7a1f3ac --- /dev/null +++ b/tests/ls/getxattr-speedup @@ -0,0 +1,64 @@ +#!/bin/sh +# Show that we've eliminated most of ls' failing getxattr syscalls, +# regardless of how many files are in a directory we list. +# This test is skipped on systems that lack LD_PRELOAD support; that's fine. +# Similarly, on a system that lacks getxattr altogether, skipping it is fine. + +# Copyright (C) 2012 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +. "${srcdir=.}/init.sh"; path_prepend_ ../src +print_ver_ ls + +# Replace each getxattr and lgetxattr call with a call to these stubs. +# Count those and write the total number of calls to the file "x" +# via a global destructor. +cat > k.c <<'EOF' || framework_failure_ +#include +#include + +static unsigned long int n_calls; + +static void __attribute__ ((destructor)) +print_call_count (void) +{ + FILE *fp = fopen ("x", "w"); if (!fp) return; + fprintf (fp, "%lu\n", n_calls); fclose (fp); +} + +static ssize_t incr () { ++n_calls; errno = ENOTSUP; return -1; } +ssize_t getxattr (const char *path, const char *name, void *value, size_t size) +{ return incr (); } +ssize_t lgetxattr(const char *path, const char *name, void *value, size_t size) +{ return incr (); } +EOF + +# Then compile/link it: +$CC -fPIC -O2 -c k.c || framework_failure_ 'failed to compile with -fPIC' +ld -G k.o -lc -o k.so || framework_failure_ 'failed to invoke ld -G ...' + +# Create a few files: +seq 20 | xargs touch || framework_failure_ + +# Finally, run the test: +LD_PRELOAD=./k.so ls --color=always -l . || fail=1 + +test -f x || skip_ "internal test failure: maybe LD_PRELOAD doesn't work?" + +# Ensure that there were no more than 3 *getxattr calls. +n_calls=$(cat x) +test "$n_calls" -le 3 || fail=1 + +Exit $fail -- cgit v1.2.3-54-g00ecf